Wrong simulation mode when using CLI option --expansion

[flomnes]

How to reproduce

Execute

antares-8.7-solver --expansion <study>

See logs

forcing the simulation mode Economy

Open question

Is it just in the logs, or is it a real bug ?

Developer notes

Antares_Simulator/src/libs/antares/study/parameters.cpp

Lines 172 to 186 in 10278e9

	const char* StudyModeToCString(StudyMode mode)
	{
	switch (mode)
	{
	case stdmEconomy:
	return "Economy";
	case stdmAdequacy:
	return "Adequacy";
	case stdmMax:
	case stdmExpansion:
	case stdmUnknown:
	return "Unknown";
	}
	return "Unknown";
	}

Antares_Simulator/src/libs/antares/study/parameters.cpp

Lines 1041 to 1058 in 10278e9

	// Simulation mode
	// ... Expansion
	if (mode == stdmExpansion)
	{
	mode = stdmEconomy;
	expansion = true;
	}
	// ... Enforcing simulation mode
	if (options.forceMode != stdmUnknown)
	{
	if (options.forceMode == stdmExpansion)
	{
	mode = stdmEconomy;
	expansion = true;
	}
	else
	mode = options.forceMode;

[flomnes]

It's only the logs. The 2nd optimization isn't run.

We only need to clarify the logs to display "Expansion".