Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate and simplify LpFilesExtractor using lists of area/interco files #815

Open
JasonMarechal25 opened this issue May 16, 2024 · 0 comments
Open

Investigate and simplify LpFilesExtractor using lists of area/interco files #815

JasonMarechal25 opened this issue May 16, 2024 · 0 comments

Comments

@JasonMarechal25
Copy link
Contributor 

          If we expect only one area and interco file, why do we use a vector to store them and check that length is 1 ? Wouldn't it be simpler to define a single path and raise an error if we try to redefine it or something like that ? This was already  like this before your PR but I think there could improvements here in the future (not to be treated in this PR though)

Originally posted by @tbittar in #797 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JasonMarechal25