Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(node): try up to 10 public nodes before failing random RPC method #2535

Merged
merged 3 commits into from
Feb 26, 2025

Conversation

fubuloubu
Copy link
Member

What I did

Ape will now retry up to 10 times before failing to find an RPC using the random public RPC feature

fixes: #2533

How I did it

Connect and make sure it is available before giving up

How to verify it

$ ape console --network :mainnet:node
WARNING:  RPC at 'https://rpc.mevblocker.io/noreverts' not available, retrying 10 more times
INFO:     Connecting to a 'mevblocker' node.

Checklist

  • All changes are completed
  • Change is covered in tests
    - [ ] Documentation is complete

@fubuloubu fubuloubu requested a review from antazoey February 26, 2025 21:40
@fubuloubu
Copy link
Member Author

note: https://github.com/ApeWorX/ape/actions/runs/13553914586/job/37883801664 actually shows retry logic working

@fubuloubu fubuloubu enabled auto-merge (squash) February 26, 2025 22:12
@fubuloubu fubuloubu disabled auto-merge February 26, 2025 22:16
antazoey
antazoey previously approved these changes Feb 26, 2025
@fubuloubu fubuloubu merged commit 981b371 into ApeWorX:main Feb 26, 2025
18 checks passed
@fubuloubu fubuloubu deleted the fix/node/try-all-public branch February 26, 2025 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

node plugin should try all options in public RPC list
4 participants