From a023cbe62044a875006d6495c1eaf3f115dd4831 Mon Sep 17 00:00:00 2001 From: Rubocop Challenger Date: Mon, 12 Feb 2024 23:31:45 +0000 Subject: [PATCH 1/3] :police_car: regenerate rubocop todo --- .rubocop_todo.yml | 33 +++++++++++++++------------------ 1 file changed, 15 insertions(+), 18 deletions(-) diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index ae394a828..44fdf9032 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -1,6 +1,6 @@ # This configuration was generated by -# `rubocop --auto-gen-config --exclude-limit 200` -# on 2023-10-11 12:02:42 UTC using RuboCop version 1.57.0. +# `rubocop --auto-gen-config --exclude-limit 180` +# on 2024-02-12 23:31:43 UTC using RuboCop version 1.60.2. # The point is for the user to remove these configuration records # one by one as the offenses are removed from the code base. # Note that changes in the inspected code, or installation of new @@ -154,7 +154,7 @@ Layout/EmptyLineBetweenDefs: - 'spec/dummy/app/controllers/pets_using_auto_views_controller.rb' - 'spec/dummy/app/controllers/pets_using_self_describing_classes_controller.rb' -# Offense count: 56 +# Offense count: 55 # This cop supports safe autocorrection (--autocorrect). Layout/EmptyLines: Exclude: @@ -192,7 +192,7 @@ Layout/EmptyLinesAroundAttributeAccessor: Exclude: - 'lib/apipie/configuration.rb' -# Offense count: 92 +# Offense count: 91 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle. # SupportedStyles: empty_lines, no_empty_lines @@ -213,7 +213,6 @@ Layout/EmptyLinesAroundBlockBody: - 'spec/lib/apipie/extractor/writer_spec.rb' - 'spec/lib/apipie/file_handler_spec.rb' - 'spec/lib/apipie/generator/swagger/param_description/composite_spec.rb' - - 'spec/lib/apipie/generator/swagger/param_description/type_spec.rb' - 'spec/lib/apipie/param_description_spec.rb' - 'spec/lib/apipie/param_group_spec.rb' - 'spec/lib/apipie/validator_spec.rb' @@ -454,7 +453,7 @@ Layout/SpaceAfterColon: Exclude: - 'spec/dummy/app/controllers/included_param_group_controller.rb' -# Offense count: 42 +# Offense count: 41 # This cop supports safe autocorrection (--autocorrect). Layout/SpaceAfterComma: Exclude: @@ -490,8 +489,9 @@ Layout/SpaceAfterNot: # Offense count: 142 # This cop supports safe autocorrection (--autocorrect). -# Configuration parameters: AllowForAlignment, EnforcedStyleForExponentOperator. +# Configuration parameters: AllowForAlignment, EnforcedStyleForExponentOperator, EnforcedStyleForRationalLiterals. # SupportedStylesForExponentOperator: space, no_space +# SupportedStylesForRationalLiterals: space, no_space Layout/SpaceAroundOperators: Exclude: - 'app/controllers/apipie/apipies_controller.rb' @@ -726,21 +726,18 @@ Lint/UnderscorePrefixedVariableName: - 'lib/apipie/application.rb' - 'lib/apipie/dsl_definition.rb' -# Offense count: 26 +# Offense count: 22 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: IgnoreEmptyBlocks, AllowUnusedKeywordArguments. Lint/UnusedBlockArgument: Exclude: - 'lib/apipie/configuration.rb' - - 'lib/apipie/extractor/collector.rb' - - 'lib/apipie/extractor/recorder.rb' - 'lib/apipie/param_description.rb' - 'lib/apipie/resource_description.rb' - 'lib/apipie/rspec/response_validation_helper.rb' - 'lib/tasks/apipie.rake' - 'spec/controllers/users_controller_spec.rb' - 'spec/lib/apipie/apipies_controller_spec.rb' - - 'spec/lib/apipie/extractor_spec.rb' - 'spec/lib/swagger/swagger_dsl_spec.rb' - 'spec/spec_helper.rb' @@ -802,7 +799,7 @@ Metrics/MethodLength: Metrics/ModuleLength: Max: 119 -# Offense count: 4 +# Offense count: 5 # Configuration parameters: CountKeywordArgs. Metrics/ParameterLists: MaxOptionalParameters: 5 @@ -974,7 +971,7 @@ RSpec/BeforeAfterAll: Exclude: - 'spec/controllers/users_controller_spec.rb' -# Offense count: 53 +# Offense count: 54 # Configuration parameters: Prefixes, AllowedPatterns. # Prefixes: when, with, without RSpec/ContextWording: @@ -1141,7 +1138,7 @@ RSpec/MessageSpies: RSpec/MultipleExpectations: Max: 19 -# Offense count: 160 +# Offense count: 163 # Configuration parameters: AllowSubject. RSpec/MultipleMemoizedHelpers: Max: 15 @@ -1166,7 +1163,7 @@ RSpec/NamedSubject: - 'spec/lib/swagger/rake_swagger_spec.rb' - 'spec/lib/swagger/swagger_dsl_spec.rb' -# Offense count: 96 +# Offense count: 97 # Configuration parameters: AllowedGroups. RSpec/NestedGroups: Max: 6 @@ -1293,7 +1290,7 @@ Rails/NegateInclude: - 'lib/apipie/extractor/writer.rb' - 'spec/spec_helper.rb' -# Offense count: 7 +# Offense count: 6 # This cop supports unsafe autocorrection (--autocorrect-all). # Configuration parameters: Include. # Include: app/**/*.rb, config/**/*.rb, db/**/*.rb, lib/**/*.rb @@ -1921,7 +1918,7 @@ Style/StringConcatenation: - 'lib/apipie/application.rb' - 'lib/apipie/extractor/writer.rb' -# Offense count: 1214 +# Offense count: 1229 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle, ConsistentQuotesInMultiline. # SupportedStyles: single_quotes, double_quotes @@ -2021,7 +2018,7 @@ Style/TrailingCommaInArrayLiteral: - 'spec/controllers/users_controller_spec.rb' - 'spec/dummy/app/controllers/pets_using_self_describing_classes_controller.rb' -# Offense count: 4 +# Offense count: 5 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyleForMultiline. # SupportedStylesForMultiline: comma, consistent_comma, no_comma From 7ed0266dc52f73c43c1c8b1e2fa513ff9ddf45ca Mon Sep 17 00:00:00 2001 From: Rubocop Challenger Date: Mon, 12 Feb 2024 23:31:50 +0000 Subject: [PATCH 2/3] :police_car: Layout/InitialIndentation --- .rubocop_todo.yml | 6 -- .../app/controllers/extending_concern.rb | 14 ++--- .../app/controllers/sample_controller.rb | 62 +++++++++---------- 3 files changed, 38 insertions(+), 44 deletions(-) diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 44fdf9032..c421e4e2e 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -386,12 +386,6 @@ Layout/IndentationWidth: - 'lib/apipie/resource_description.rb' - 'lib/tasks/apipie.rake' -# Offense count: 2 -# This cop supports safe autocorrection (--autocorrect). -Layout/InitialIndentation: - Exclude: - - 'spec/dummy/app/controllers/extending_concern.rb' - - 'spec/dummy/app/controllers/sample_controller.rb' # Offense count: 15 # This cop supports safe autocorrection (--autocorrect). diff --git a/spec/dummy/app/controllers/extending_concern.rb b/spec/dummy/app/controllers/extending_concern.rb index 528505a8a..4c1cb7900 100644 --- a/spec/dummy/app/controllers/extending_concern.rb +++ b/spec/dummy/app/controllers/extending_concern.rb @@ -1,10 +1,10 @@ - module ExtendingConcern - extend Apipie::DSL::Concern +module ExtendingConcern + extend Apipie::DSL::Concern - update_api(:create) do - param :user, Hash do - param :from_concern, String, :desc => 'param from concern', :allow_nil => false - end - meta metadata: 'data' + update_api(:create) do + param :user, Hash do + param :from_concern, String, :desc => 'param from concern', :allow_nil => false end + meta metadata: 'data' end +end diff --git a/spec/dummy/app/controllers/sample_controller.rb b/spec/dummy/app/controllers/sample_controller.rb index 89fa5e92a..73b8eeaac 100644 --- a/spec/dummy/app/controllers/sample_controller.rb +++ b/spec/dummy/app/controllers/sample_controller.rb @@ -1,39 +1,39 @@ - module SampleController - extend Apipie::DSL::Concern +module SampleController + extend Apipie::DSL::Concern - api! - def index - render :plain => "OK #{params.inspect}" - end + api! + def index + render :plain => "OK #{params.inspect}" + end - api :GET, '/:resource_id/:id' - param :id, String - def show - render :plain => "OK #{params.inspect}" - end + api :GET, '/:resource_id/:id' + param :id, String + def show + render :plain => "OK #{params.inspect}" + end - def_param_group :concern do - param :concern, Hash, :required => true, :action_aware => true do - param :name, String, "Name of a :concern" - param :concern_type, String - end + def_param_group :concern do + param :concern, Hash, :required => true, :action_aware => true do + param :name, String, "Name of a :concern" + param :concern_type, String end + end - api :POST, '/:resource_id', "Create a :concern" - param_group :concern - def create - render :plain => "OK #{params.inspect}" - end + api :POST, '/:resource_id', "Create a :concern" + param_group :concern + def create + render :plain => "OK #{params.inspect}" + end - api :PUT, '/:resource_id/:id' - param :id, String - param_group :concern - def update - render :plain => "OK #{params.inspect}" - end + api :PUT, '/:resource_id/:id' + param :id, String + param_group :concern + def update + render :plain => "OK #{params.inspect}" + end - api :GET, '/:resource_id/:custom_subst' - def custom - render :plain => "OK #{params.inspect}" - end + api :GET, '/:resource_id/:custom_subst' + def custom + render :plain => "OK #{params.inspect}" end +end From e71e4e070de63de0df864e3f2256a0b991243e32 Mon Sep 17 00:00:00 2001 From: Rubocop Challenger Date: Mon, 12 Feb 2024 23:32:01 +0000 Subject: [PATCH 3/3] :police_car: regenerate rubocop todo --- .rubocop_todo.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index c421e4e2e..468a77814 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -1,6 +1,6 @@ # This configuration was generated by # `rubocop --auto-gen-config --exclude-limit 180` -# on 2024-02-12 23:31:43 UTC using RuboCop version 1.60.2. +# on 2024-02-12 23:31:59 UTC using RuboCop version 1.60.2. # The point is for the user to remove these configuration records # one by one as the offenses are removed from the code base. # Note that changes in the inspected code, or installation of new @@ -386,7 +386,6 @@ Layout/IndentationWidth: - 'lib/apipie/resource_description.rb' - 'lib/tasks/apipie.rake' - # Offense count: 15 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: AllowDoxygenCommentStyle, AllowGemfileRubyComment.