-
-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collaborator push into PR during the CI upload of data test running causes upload to stop #2732
Comments
Not sure whether it is a race condition or something else but I'd love to fix this - if I only knew how. |
As a temporary workaround: |
Not a workaround, but a pre-check before merging a PR would be to check if the commit |
I think you could streamline your PR much more using more of GitHub Actions based flow instead of Travis CI based shell script and including auto commits for PR and auto merges too. |
Want to help @humble-barnacle001? Seems like you know a lot more about GitHub Actions than me. |
Sure, I'll take a look at it when I am free from my school commitments |
In case I create a pull request and all the conditions pass, the database and apps folder is not updated since I'm not the owner. It shall be pushed only when owner pushes to the branch.
But suppose, I create a PR after which owner actually pushes to it (dummy) to generate the files but, I update the fork's branch before the test for the owner's push is completed then the action running on owner's push is cancelled and hence the files in the database/ and apps/ is not pushed.
Then the PR may be merged to wrongly assume that the required files have already been generated and added when it is in fact so. See #2728 and 28a5eb3
The text was updated successfully, but these errors were encountered: