Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

accept AppImages from bitbucket downloads, second attempt #3250

Open
kfjahnke opened this issue Sep 11, 2023 · 2 comments
Open

accept AppImages from bitbucket downloads, second attempt #3250

kfjahnke opened this issue Sep 11, 2023 · 2 comments

Comments

@kfjahnke
Copy link
Contributor

Since you closed #3211, I open a new issue: you applied the patch which removed my contribution and closed the issue, but this does not resolve it. Without the bitbucket-specific code, bitbucket repos with download section will not result in a download button. I suggested you test the remainder of the code after applying the patch, to make sure that removal of my code does indeed remove the problems you encountered with non-bitbucket catalog entries, but you did not report back about that, and instead just left the tentative patch in place, effectively disabling my code. I realize that bitbucket repos occur only in a small percentage of the catalog entries, so maybe you prefer not having specific code for them after all? I could live with that - after all the download section is just a click away from the main page of the repo. What do you say? If you do want the bitbucket code after all, I can send a patch to un-comment it, if you don't want it, we might as well remove the commented-out code altogether.

@probonopd
Copy link
Member

Thanks for the reminder. Indeed I was sidetracked with other work.
What do I need to merge so that we get a Download button for Bitbucket projects that actually are hosting an AppImage on Bitbucket, but will not make all tests tail that are not hosted on BitBucket?

#3236 (comment)

Am a bit overloaded with other work at the moment, so if you could send a ready-to-pull PR that would be a big help indeed.

Sorry for the delay!

@kfjahnke
Copy link
Contributor Author

See #3258.
Please try and re-run worker.sh with a variety of sources to establish whether you get failing tests again! AFAICT the bitbucket-related code works as intended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants