Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single Image Server Node #87

Open
swiz23 opened this issue Jan 13, 2021 · 1 comment
Open

Single Image Server Node #87

swiz23 opened this issue Jan 13, 2021 · 1 comment

Comments

@swiz23
Copy link

swiz23 commented Jan 13, 2021

I noticed that one of the parameters taken in by this node is the desired camera_frame.
However, when calling the ROS service, instead of sticking the frame specified by camera_frame, it just sticks 'camera' as the frame of reference. Why doesn't it use the frame in camera_frame?

You can see the line in question at

loaded_image->header.frame_id = "camera";

@wxmerkt
Copy link
Collaborator

wxmerkt commented Jan 13, 2021

The single image service loads from a file on disk which may not be the same as the camera specified in starting the node. However, I agree that you want to reuse that specified camera_frame for tfs etc. - happy to accept a PR to change this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants