Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shorten Posts: Size calculation out of date #1396

Open
marcustyphoon opened this issue Feb 5, 2024 · 0 comments
Open

Shorten Posts: Size calculation out of date #1396

marcustyphoon opened this issue Feb 5, 2024 · 0 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@marcustyphoon
Copy link
Collaborator

Platform

MacOS 14.2.1 arm64

Browser

Safari 17.2.1

Addon version

0.23.3

Details

--available-space: calc(100vh - 54px - 20px);
--shortened-post-height: calc((var(--available-space) * var(--xkit-shorten-posts-max-height)) - 20px);
--expand-button-total-height: calc(1rem + (var(--post-header-vertical-padding) * 2));

This code calculated the available height for posts based on the old layout with the header and is now incorrect in both the desktop layout (which has no header) and the mobile layout (which has a 44px header).

@marcustyphoon marcustyphoon added bug Something isn't working help wanted Extra attention is needed labels Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant