Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest tags from post reblogged not working on firefox mobile #1611

Open
watisdatvelvet opened this issue Sep 9, 2024 · 3 comments · May be fixed by #1612
Open

Suggest tags from post reblogged not working on firefox mobile #1611

watisdatvelvet opened this issue Sep 9, 2024 · 3 comments · May be fixed by #1612
Assignees
Labels
bug Something isn't working

Comments

@watisdatvelvet
Copy link

Platform

Android 14

Browser

Firefox Beta 131.0b3 (Build #2016042863),

Addon version

1.03

Details

have no problems using this feature on desktop chrome but mobile firefox beta (i believe beta is necessary for the extension?) does not display any menu for tags from previous post.
Screenshot_20240909-150953

@watisdatvelvet watisdatvelvet added the bug Something isn't working label Sep 9, 2024
@marcustyphoon
Copy link
Collaborator

Ah, darn—it looks like Firefox for Android doesn't support the standard datalist webpage component we're using here, per a 6-year-old Firefox bug tracker item. We would have to manually write a new interface to display and allow the selection of tag suggestions to fix this, I guess, unless Mozilla finishes adding it.

Kind of curious if this works in Kiwi Browser for Android.

(also, side note that while it did used to be required, as of a while ago using the beta version of Firefox for Android is no longer necessary for web extension support!)

@watisdatvelvet
Copy link
Author

thanks for the suggestion, it does work in kiwi browser! (the drop-down isn't fixed to the quick reblogs frame like on desktop, but i assume that's more an android goof)
Screenshot_20240910-010755

@marcustyphoon
Copy link
Collaborator

marcustyphoon commented Sep 10, 2024

Interesting; I guess it is... at least sort of possible to make this kind of interface in Android.

I would honestly love to replace the datalist component we have with something custom anyway, as there are a whole bunch of quite bad limitations with the current setup (#1102, the fact that the suggestions include the current text in the tags box, etc). I'll give it a try, though the code will probably be a bit of a mess :D

(I think this should probably stay open in any case; Firefox for Android is one of our supported platforms, and this is a feature people want! We can tag it wontfix if we don't have a solution.)

@marcustyphoon marcustyphoon reopened this Sep 10, 2024
@marcustyphoon marcustyphoon self-assigned this Sep 10, 2024
@marcustyphoon marcustyphoon linked a pull request Sep 10, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants