Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not compliant with IDNA spec. #15

Open
joshuawu opened this issue May 20, 2019 · 1 comment
Open

Not compliant with IDNA spec. #15

joshuawu opened this issue May 20, 2019 · 1 comment

Comments

@joshuawu
Copy link

namehash accepts a lot of names with non-IDNA-compliant characters such as any emoji. Emoji are not valid in IDNs as they don't even belong in PVALID.

// Expected:
> namehash.hash('✝️')
Error

// Actual:
> namehash.hash('✝️')
'0xd163ee58661439a2343c6240ad1626b4e0ef502e8d83d3ecddc660981e286078'
@joshuawu
Copy link
Author

In case anyone is wondering why I'm mentioning IDNA: UTS-46 is a spec made for compatibility between IDNA 2008 and IDNA 2003. There's little point performing the UTS-46 conversions without supporting IDNA in the first place. Otherwise we might as well not implement UTS-46 and instead only perform Unicode case-folding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@joshuawu