Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query on Disassembler Option: multilabel on/off #15

Closed
phillipeaton opened this issue Sep 17, 2022 · 3 comments
Closed

Query on Disassembler Option: multilabel on/off #15

phillipeaton opened this issue Sep 17, 2022 · 3 comments

Comments

@phillipeaton
Copy link

phillipeaton commented Sep 17, 2022

In the Disassembler Options documentation, it has:

multilabel on|off
nomultilabel
can be used to decide whether multiple labels can be set for a single address.
Default is off.

If I set this to on with a 6502 disassembly, it doesn't seem to do anything...but I'm not sure exactly what it should be doing.

The picture below is from the Infiltrator disassembler, it's created mulitple labels for $8100 (which is on line 211), I'm assuming dasmfw multilabel does something similar regarding multiple labels?

image

The picture below is some 6502 code produced by dasmfw with multilabel on, there are multiple calls to a single address TJOC_RTS, but only a single label produced.

image

My info options file is:

image

Any clues?

@phillipeaton phillipeaton changed the title Query on Query on Disassembler Option: multilabel on/off Sep 17, 2022
@phillipeaton
Copy link
Author

Additional feedback: If I leave the multilabel option on, some of my labels don't make it into the generated source code file and the later assembly fails. (I recall seeing some warnings somewhere about multilabel, there may be gotchas.)

@phillipeaton
Copy link
Author

After seeing the below comment with the context of the other thread, I think that multilabel doesn't work in the way I am expecting, as described earlier in this thread.

You can therefore either Close this Issue or consider it as a Feature Request that I would find very useful!


You can either write
label 0d ZP_Color_RAM_PtrX+1
or tell dasmfw that multiple labels are allowed for an address by setting
option multilabel on

I'd suggest the first, however - using multiple labels for an address opens a can of very ugly worms.

Originally posted by @Arakula in #13 (comment)

@phillipeaton
Copy link
Author

Moved to Feature suggestion: Show Label Call Addresses

@phillipeaton phillipeaton closed this as not planned Won't fix, can't repro, duplicate, stale Nov 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant