Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block Duplication Bug When Using AuraSkills with ItemsAdder #289

Open
3 tasks done
G-JLING opened this issue Jun 5, 2024 · 3 comments
Open
3 tasks done

Block Duplication Bug When Using AuraSkills with ItemsAdder #289

G-JLING opened this issue Jun 5, 2024 · 3 comments
Assignees
Labels
type: bug Something is not working as intended

Comments

@G-JLING
Copy link

G-JLING commented Jun 5, 2024

Server software and version

Paper 1.20.1

Expected behavior

Mining the block should drop the correct number of items without duplication.

Actual behavior

Mining the block results in multiple drops of the same item, leading to duplication.

How to reproduce

  1. Ensure the server is running Paper 1.20.1 with the latest builds of AuraSkills and ItemsAdder installed.
  2. Configure a profession in AuraSkills to gain experience from a specific block (e.g., "miner" from "ancient_debris").
  3. Place a note_block and then place the specific block (e.g., "ancient_debris") next to it.
  4. Mine the specific block.
  5. Observe that multiple identical blocks are dropped.
  • The duplicated block must be a source of experience for a profession in the AuraSkills plugin. For example, if the profession "miner" gains experience from mining "ancient_debris," placing "ancient_debris" next to a note block and then mining it will cause the duplication.
  • Removing either AuraSkills or ItemsAdder resolves the issue.

Additional information

Removing either AuraSkills or ItemsAdder resolves the issue, but this is not ideal as both plugins are needed for the server's functionality.
截屏2024-06-05 18 17 44

Agreements

@G-JLING G-JLING added the type: bug Something is not working as intended label Jun 5, 2024
@Archy-X
Copy link
Owner

Archy-X commented Jun 8, 2024

ItemsAdder might be canceling the BlockPlaceEvent and using their own, so AuraSkills can't detect the ancient debris as a player placed block. I believe ItemsAdder has a CustomBlockPlaceEvent for this but it's hard to know what's going on since its closed source and I can't test it. Anyone can feel free to PR to add support if they need this quickly.

@G-JLING
Copy link
Author

G-JLING commented Jun 8, 2024

OK. Thank you for your response.

@Perwollnt
Copy link

If you are willing to test what I made I can create a custom fork that attempts to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something is not working as intended
Projects
None yet
Development

No branches or pull requests

3 participants