Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of SVF file (ds_param.nc) not desired when cleaning? #57

Open
joelfiddes opened this issue Feb 23, 2023 · 4 comments
Open

Removal of SVF file (ds_param.nc) not desired when cleaning? #57

joelfiddes opened this issue Feb 23, 2023 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers topoClass

Comments

@joelfiddes
Copy link
Collaborator

  • If we want to clean the sim it is normally to remove results and change some parameters eg cluster number.
  • The only reason to remove ds_param.nc it is because we have changed the dem.
  • On big domains, the SVF computation can take a long time (hrs) and therefore a pain to recompute when restarting a sim.
  • It is desirable to remove ds_param.nc from the cleaning routine I think - we could write it to the dem directory as it belongs together with the dem I think?
@joelfiddes joelfiddes added the enhancement New feature or request label Feb 23, 2023
@ArcticSnow
Copy link
Owner

good point Joel. I ran into this behavior that is frustrating, indeed. We could instead have an overwrite flag in the compute_dem_parameter(). Would that be a good alternative?

@joelfiddes
Copy link
Collaborator Author

yup - i think that would be a good solution. We still need write ds_param.nc to dem dir or else it is removed by:

if self.config.outputs.file.clean_outputs: # remove outputs directory because if results already exist this causes concat of netcdf files try: shutil.rmtree(self.config.project.directory + '/outputs/') print('---> Output directory cleaned') except: os.makedirs('/'.join((self.config.project.directory, 'outputs/')))

@ShawanDeba
Copy link

Hi everyone. can anyone just give me a gist of what I need to do? then I can proceed with the work

@joelfiddes
Copy link
Collaborator Author

@ShawanDeba Welcome aboard! If you would like to get involved a first good step would be to try deploy the code on your laptop (linux is best) and run the examples https://github.com/ArcticSnow/TopoPyScale_examples then will be easier to get into the code. I can give some pointers once you have a first successful run of the code. Let me know if you get stuck anywhere. Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers topoClass
Projects
None yet
Development

No branches or pull requests

3 participants