Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix compiler flags in ytk and ydk on OSX (define DISABLE_VISIBILITY) #877

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix compiler flags in ytk and ydk on OSX (define DISABLE_VISIBILITY) #877

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c6300e0
fix compiler flags in ytk and ydk on OSX (define DISABLE_VISIBILITY)
paseri3739 Mar 5, 2024
a0c7ccf
patch
paseri3739 Mar 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 38 additions & 0 deletions changes.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
From c6300e0a430fe07a6d6efe78acab831245a0b390 Mon Sep 17 00:00:00 2001
From: paseri3739 <[email protected]>
Date: Tue, 5 Mar 2024 11:10:34 +0900
Subject: [PATCH] fix compiler flags in ytk and ydk on OSX (define
DISABLE_VISIBILITY)

---
libs/tk/ydk/wscript | 1 +
libs/tk/ytk/wscript | 1 +
2 files changed, 2 insertions(+)

diff --git a/libs/tk/ydk/wscript b/libs/tk/ydk/wscript
index 45e04326b3..e2eb99ee32 100644
--- a/libs/tk/ydk/wscript
+++ b/libs/tk/ydk/wscript
@@ -188,6 +188,7 @@ def build(bld):
obj.cflags += ['-xobjective-c']
obj.uselib += ' OSX' # -framework Cocoa -framework CoreFoundation -framework ApplicationServices
obj.includes += ['ydk/quartz', 'ydk/quartz/gdk', 'ydk/gdk/quartz']
+ obj.defines += ['DISABLE_VISIBILITY']
obj.export_includes += ['ydk/gdk']
obj.export_includes += ['ydk/quartz']
elif bld.env['build_target'] == 'mingw':
diff --git a/libs/tk/ytk/wscript b/libs/tk/ytk/wscript
index a921a79863..3701fcf02a 100644
--- a/libs/tk/ytk/wscript
+++ b/libs/tk/ytk/wscript
@@ -300,6 +300,7 @@ def build(bld):
obj.source = libytk_sources + libytk_quartz_sources
obj.cflags += ['-xobjective-c']
obj.uselib += ' OSX' # -framework Cocoa -framework CoreFoundation -framework ApplicationServices
+ obj.defines += ['DISABLE_VISIBILITY']
elif bld.env['build_target'] == 'mingw':
obj.source = libytk_sources + libytk_win32_sources
obj.defines += [ 'INSIDE_GTK_WIN32', 'DLL_EXPORT', 'PIC' ]
--
2.39.3 (Apple Git-145)

1 change: 1 addition & 0 deletions libs/tk/ydk/wscript
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,6 +188,7 @@ def build(bld):
obj.cflags += ['-xobjective-c']
obj.uselib += ' OSX' # -framework Cocoa -framework CoreFoundation -framework ApplicationServices
obj.includes += ['ydk/quartz', 'ydk/quartz/gdk', 'ydk/gdk/quartz']
obj.defines += ['DISABLE_VISIBILITY']
obj.export_includes += ['ydk/gdk']
obj.export_includes += ['ydk/quartz']
elif bld.env['build_target'] == 'mingw':
Expand Down
1 change: 1 addition & 0 deletions libs/tk/ytk/wscript
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,6 +300,7 @@ def build(bld):
obj.source = libytk_sources + libytk_quartz_sources
obj.cflags += ['-xobjective-c']
obj.uselib += ' OSX' # -framework Cocoa -framework CoreFoundation -framework ApplicationServices
obj.defines += ['DISABLE_VISIBILITY']
elif bld.env['build_target'] == 'mingw':
obj.source = libytk_sources + libytk_win32_sources
obj.defines += [ 'INSIDE_GTK_WIN32', 'DLL_EXPORT', 'PIC' ]
Expand Down