From 67700f0d35afa042905b990323ed3a76075f0126 Mon Sep 17 00:00:00 2001
From: Roger Yang <80478925+RogerHYang@users.noreply.github.com>
Date: Thu, 13 Feb 2025 15:39:57 -0800
Subject: [PATCH] fix: missing slash in examples url printed after dataset
 upload (#6378)

---
 src/phoenix/session/client.py | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/src/phoenix/session/client.py b/src/phoenix/session/client.py
index d32a305b61..b24a4ab517 100644
--- a/src/phoenix/session/client.py
+++ b/src/phoenix/session/client.py
@@ -8,7 +8,7 @@
 from io import BytesIO
 from pathlib import Path
 from typing import Any, BinaryIO, Literal, Optional, Union, cast
-from urllib.parse import quote
+from urllib.parse import quote, urljoin
 
 import httpx
 import pandas as pd
@@ -760,12 +760,14 @@ def _process_dataset_upload_response(self, response: Response) -> Dataset:
             raise
         data = response.json()["data"]
         dataset_id = data["dataset_id"]
-        response = self._client.get(url=f"v1/datasets/{dataset_id}/examples")
+        path = f"v1/datasets/{dataset_id}/examples"
+        response = self._client.get(path)
         response.raise_for_status()
         data = response.json()["data"]
         version_id = data["version_id"]
         examples = data["examples"]
-        print(f"💾 Examples uploaded: {self.web_url}datasets/{dataset_id}/examples")
+        examples_url = urljoin(self.web_url, path)
+        print(f"💾 Examples uploaded: {examples_url}")
         print(f"🗄️ Dataset version ID: {version_id}")
 
         return Dataset(