Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance: Sparse adam #16

Closed
ArthurBrussee opened this issue Nov 11, 2024 · 1 comment
Closed

Performance: Sparse adam #16

ArthurBrussee opened this issue Nov 11, 2024 · 1 comment

Comments

@ArthurBrussee
Copy link
Owner

Gradients are already calculated as sparse gradients. As a very final step, these are then made dense again and fed to the optimizer.

We'd ideally have a sparse adam optimizer. It'd be great if this was a re-usable library for Burn, but more likely it'd mean just implementing this as a custom kernel.

@ArthurBrussee
Copy link
Owner Author

After some discussions, I think #38 is the more fruitful direction. Sparse adam is not a big win as momenta will be dense anyway. Taking multiple images/step will also make the gradients more "dense"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant