From ba5cb339fe6f51ed1603ec1a72bfe072f8407f51 Mon Sep 17 00:00:00 2001 From: noacoohen Date: Thu, 5 Sep 2024 11:29:07 +0300 Subject: [PATCH 1/4] remove live-test build --- .github/workflows/buildsCI.yaml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/buildsCI.yaml b/.github/workflows/buildsCI.yaml index 0b9185d670..a58f74ac06 100644 --- a/.github/workflows/buildsCI.yaml +++ b/.github/workflows/buildsCI.yaml @@ -302,8 +302,7 @@ jobs: continue-on-error: true run: | export LRS_LOG_LEVEL="DEBUG"; - cd build/${{env.LRS_RUN_CONFIG}}/ - ./live-test -d yes -i [software-device] + cd build/${{env.LRS_RUN_CONFIG}}/ - name: Upload RS log artifact uses: actions/upload-artifact@v4 From 2492c7ee768a9ef96c5e8e8411b6dc5ccbd76694 Mon Sep 17 00:00:00 2001 From: noacoohen Date: Sun, 8 Sep 2024 09:05:33 +0300 Subject: [PATCH 2/4] remove test section and rename the run --- .github/workflows/buildsCI.yaml | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/.github/workflows/buildsCI.yaml b/.github/workflows/buildsCI.yaml index a58f74ac06..7fe4b15149 100644 --- a/.github/workflows/buildsCI.yaml +++ b/.github/workflows/buildsCI.yaml @@ -260,7 +260,7 @@ jobs: #-------------------------------------------------------------------------------- - U20_U24_ST_Py_EX_CfU_LiveTest: # Ubuntu, Static, Python, Examples & Tools, Check for Updates + U22_U24_ST_Py_EX_CfU: # Ubuntu, Static, Python, Examples & Tools, Check for Updates runs-on: ${{ matrix.os }} strategy: matrix: @@ -293,16 +293,6 @@ jobs: cd build cmake .. -DCMAKE_BUILD_TYPE=${{env.LRS_RUN_CONFIG}} -DBUILD_SHARED_LIBS=false -DBUILD_EXAMPLES=true -DBUILD_TOOLS=true -DCHECK_FOR_UPDATES=true -DBUILD_PYTHON_BINDINGS=true -DPYTHON_EXECUTABLE=$(which python3) cmake --build . -- -j4 - - - name: Test - shell: bash - id: test-step - # We set continue-on-error: true as a workaround for not skipping the upload log step on failure, - # The final step will check the return value from the test step and decide if to fail/pass the job - continue-on-error: true - run: | - export LRS_LOG_LEVEL="DEBUG"; - cd build/${{env.LRS_RUN_CONFIG}}/ - name: Upload RS log artifact uses: actions/upload-artifact@v4 From ee497b97368e6f7965c860343a61da7480d33f4c Mon Sep 17 00:00:00 2001 From: noacoohen Date: Sun, 8 Sep 2024 10:12:42 +0300 Subject: [PATCH 3/4] remove Upload RS log artifact --- .github/workflows/buildsCI.yaml | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/.github/workflows/buildsCI.yaml b/.github/workflows/buildsCI.yaml index 7fe4b15149..bb4ff355ea 100644 --- a/.github/workflows/buildsCI.yaml +++ b/.github/workflows/buildsCI.yaml @@ -270,7 +270,7 @@ jobs: name: U22 - os: ubuntu-24.04 name: U24 - name: ${{ matrix.name }}_ST_Py_EX_CfU_LiveTest + name: ${{ matrix.name }}_ST_Py_EX_CfU timeout-minutes: 60 steps: - uses: actions/checkout@v4 @@ -294,12 +294,6 @@ jobs: cmake .. -DCMAKE_BUILD_TYPE=${{env.LRS_RUN_CONFIG}} -DBUILD_SHARED_LIBS=false -DBUILD_EXAMPLES=true -DBUILD_TOOLS=true -DCHECK_FOR_UPDATES=true -DBUILD_PYTHON_BINDINGS=true -DPYTHON_EXECUTABLE=$(which python3) cmake --build . -- -j4 - - name: Upload RS log artifact - uses: actions/upload-artifact@v4 - with: - name: Log file - ${{ matrix.name }}_ST_Py_EX_CfU_LiveTest - path: build/${{env.LRS_RUN_CONFIG}}/*.log - - name: Provide correct exit status for job shell: bash run: | From 65e3d705ac372afd32d9c2a391be169d28a89e61 Mon Sep 17 00:00:00 2001 From: noacoohen Date: Sun, 8 Sep 2024 15:27:11 +0300 Subject: [PATCH 4/4] fix PR comments --- .github/workflows/buildsCI.yaml | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/.github/workflows/buildsCI.yaml b/.github/workflows/buildsCI.yaml index bb4ff355ea..bc46e5bed6 100644 --- a/.github/workflows/buildsCI.yaml +++ b/.github/workflows/buildsCI.yaml @@ -294,16 +294,6 @@ jobs: cmake .. -DCMAKE_BUILD_TYPE=${{env.LRS_RUN_CONFIG}} -DBUILD_SHARED_LIBS=false -DBUILD_EXAMPLES=true -DBUILD_TOOLS=true -DCHECK_FOR_UPDATES=true -DBUILD_PYTHON_BINDINGS=true -DPYTHON_EXECUTABLE=$(which python3) cmake --build . -- -j4 - - name: Provide correct exit status for job - shell: bash - run: | - if [ ${{steps.test-step.outcome}} = "failure" ];then - echo "Test step failed, please open it to view the reported issue" - exit 1 - else - exit 0 - fi - #-------------------------------------------------------------------------------- U20_SH_Py_CI: # Ubuntu 2020, Shared, Python, LibCI with executables