Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: "Input Variable" event command should not allow boolean variable selection #1173

Closed
AlexVild opened this issue Mar 31, 2022 · 1 comment · Fixed by #2481
Closed

bug: "Input Variable" event command should not allow boolean variable selection #1173

AlexVild opened this issue Mar 31, 2022 · 1 comment · Fixed by #2481
Labels
bug Something isn't working verified Issue has been verified as valid/existing.

Comments

@AlexVild
Copy link
Contributor

Describe the bug
If you use the Input Variable event command with a boolean-type variable, you will be given a dialog menu with no input field. Neither selection in the menu changes the variable's value - seems to imply that booleans shouldn't be available for selection for this command.

Version Encountered

7.0 Stable

To Reproduce
Steps to reproduce the behavior:

  1. Make a boolean player variable
  2. Make an event that uses "Input Variable" event on that var
  3. You can try to change the var in the event, but it will not do anything to the variable's value.

Expected behavior
I propose just not allowing input variables to be of type boolean.

Screenshots
image

Neither option changes the variable's value.

@AlexVild AlexVild added the bug Something isn't working label Mar 31, 2022
@Arufonsu Arufonsu added the verified Issue has been verified as valid/existing. label Jul 3, 2022
@WeylonSantana
Copy link
Contributor

Just bringing thoughts, I would say it's actually easy, just create a bool "isString" and a checkbox in the input editor, if you check cmbVariavel it will only show variables of type string, if not, only variables of type number.

I would do that, but there is the issue of migrating to all existing games that already use the inputs, for guilds and so on, all the indexes would be wrong, so I'll pass =D, but there's a simple alternative above, the complicated thing is just the migration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working verified Issue has been verified as valid/existing.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants