Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Refactor Entity#TryAttack/Attack and its variations #1642

Open
1 task done
AlexVild opened this issue Oct 24, 2022 · 0 comments
Open
1 task done

chore: Refactor Entity#TryAttack/Attack and its variations #1642

AlexVild opened this issue Oct 24, 2022 · 0 comments
Assignees
@AlexVild
Labels
chore Cleans up code, documentation or project structure without altering functionality

Comments

@AlexVild
Copy link
Contributor

Description

The whole flow for attacking is an absolute nightmare to nagivate/expand upon, whether via melee, spells, or projectiles.

It could/should be much simpler/fragmented, and it would benefit further modification greatly to get it all squared away.

Intended Use-Case

Improve future code modifications by simplifying code base and limiting massive "omni" functions in the player.

Duplicate Check

  • This enhancement idea is not a duplicate to the best of my knowledge.
@AlexVild AlexVild added the enhancement Minor feature addition or quality of life change label Oct 24, 2022
@AlexVild AlexVild self-assigned this Oct 24, 2022
@lodicolo lodicolo changed the title enhancement: Refactor Entity#TryAttack/Attack and its variations chore: Refactor Entity#TryAttack/Attack and its variations Nov 3, 2023
@lodicolo lodicolo added chore Cleans up code, documentation or project structure without altering functionality and removed enhancement Minor feature addition or quality of life change labels Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlexVild AlexVild

Labels
chore Cleans up code, documentation or project structure without altering functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lodicolo @AlexVild