feature: Access to Source of Dropped/Spawned Items for Server Plugins #2390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lodicolo
requested changes
Oct 21, 2024
lodicolo
requested changes
Oct 25, 2024
lodicolo
requested changes
Oct 29, 2024
|
Leaving this comment as a note to confirm that I've been testing the item source implementation in a test plugin, and everything has been working as expected. |
lodicolo
approved these changes
Nov 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will allow access to the source of an item that is dropped/spawned on the map. The main goal is to expose this logic to the plugin system, specifically in the context of the server. It’s still a work in progress, but I would like to keep updating the draft in case they have any suggestions for the changes.