Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Encounter builder search is unresponsive #222

Open
Weaver-Unseen opened this issue Aug 21, 2021 · 2 comments · May be fixed by #223
Open

Encounter builder search is unresponsive #222

Weaver-Unseen opened this issue Aug 21, 2021 · 2 comments · May be fixed by #223

Comments

@Weaver-Unseen
Copy link

Hi all,

I'm trying to use Kobold Fight Club's encounter builder, but the search function is unresponsive. I can type the name of a creature into the search bar, but nothing comes up in the search. I've attempted to fix the problem by clearing my cache and deleting my local storage, but neither have worked.

I use an an HP Spectre laptop running Windows 10 Home 64. I've tried to use the encounter builder on both Chrome (ver. 92.0.4515.159 64-bit) and Firefox (ver. 91.0 64-bit).

Any help is greatly appreciated - this site is invaluable to my encounter-building!

Thanks,

Weaver
Lnaden added a commit to Lnaden/5e-monsters that referenced this issue Aug 21, 2021
@Lnaden
Update the Google Sheets API calls to v4
76b8a79 
This PR updates the API calls to Google Sheets to use v4 instead of v3
which was shut down August 2.

Fixes Asmor#217, Fixes Asmor#218, and Fixes Asmor#222 with some caveats, see below.

Full disclosure: I have no idea what I'm doing really with JS, so there
are likely to be improvements to be made.

Potentially Outstanding Issues:
* Uses my personal API Key. Its restricted to Google Sheets API only,
  but I would prefer it be someone else's. Not really a problem right now.
* Each Sheet is loaded in full through a GET request, returned entierly
  as JSON. This results in the load being a bit slow (and a fair amount
  of data comes down, the Official is 33MB of plain text returned for
  example. The load only happens once per sheet.
* I left in all the old code where I could in case improvements can be
  made.
* I do not know JS, so any improvements, especially in the Promises
  area are likely very welcome.
@Lnaden Lnaden linked a pull request Aug 21, 2021 that will close this issue
Open
Lnaden added a commit to Lnaden/5e-monsters that referenced this issue Aug 22, 2021
@Lnaden
Update the Google Sheets API calls to v4
8886bda 
This PR updates the API calls to Google Sheets to use v4 instead of v3
which was shut down August 2.

Fixes Asmor#217, Fixes Asmor#218, and Fixes Asmor#222 with some caveats, see below.

Full disclosure: I have no idea what I'm doing really with JS, so there
are likely to be improvements to be made.

Potentially Outstanding Issues:
* Uses my personal API Key. Its restricted to Google Sheets API only,
  but I would prefer it be someone else's. Not really a problem right now.
* Each Sheet is loaded in full through a GET request, returned entierly
  as JSON. This results in the load being a bit slow (and a fair amount
  of data comes down, the Official is 33MB of plain text returned for
  example. The load only happens once per sheet.
* I left in all the old code where I could in case improvements can be
  made.
* I do not know JS, so any improvements, especially in the Promises
  area are likely very welcome.

Removed some debug lines I left in sending to console.
@SteveyFreaq
Copy link

I've replicated this on two different machines on two separate browsers. Do we have any idea when this will be resolved?

Windows 10 Home 20H2 19042.1165, on Firefox 91.0.1 and Chrome 92.0.4515.159
Windows 10 Pro 20h2 19042.1165, on Chrome 92.0.4515.159

@DemPap96
Copy link

I have the same problem. I don't get a response on searching. I see content under the Manage Content button (Community, Official, Third Party) but I don't see sources under the Set Sources button (only add additional content).

Capture
Capture2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update the Google Sheets API calls to v4 Lnaden/5e-monsters
3 participants
@Weaver-Unseen @SteveyFreaq @DemPap96