Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out how to properly do version and name of pymetis package #53

Open
hugobuddel opened this issue Nov 5, 2024 · 0 comments
Open

Comments

@hugobuddel
Copy link
Contributor

@ivh (accidentally) committed c81377c to get the package to install.

Slack conversation:

Thomas

sht, I just pushed to METIS_Pipeline a change to pymetis/pyproject.toml, while I only intend to push to my fork and make a pull-request.

sorry, if that breaks sth. But I needed to add the project name to that file, otherwise the python packade did install with name UNKNOWN and nothing worked.

Gilles

i noticed that error too

Hugo

I think that if you install everything through the official tools, that then a setup.cfg will be created that has the name and version

There is a makefile with placeholders for the version: https://github.com/AstarVienna/METIS_Pipeline/blob/main/metisp/pymetis/setup.cfg.in
setup.cfg.in

Thomas

what step exaclty does the setup.cfg ? I ran the commands from metisp/README.md

Hugo

I had it working with the cmake instructions, but I put the autotools instructions in the README. But maybe I messed something up

Let's keep it as is for now and figure out how to do it properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant