Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove additional_observation_spaces in favor of wrappers #87

Open
mickvangelderen opened this issue Nov 15, 2024 · 0 comments
Open

Remove additional_observation_spaces in favor of wrappers #87

mickvangelderen opened this issue Nov 15, 2024 · 0 comments

Comments

@mickvangelderen
Copy link
Contributor

          An alternative to this is to always return zero and implement wrappers for each game that set the reward. That seems a bit nicer to me in terms of layering things.

Same goes for the observation spaces. The base class here could just return an image and everything else in the info dict, and the wrapper could parse things from info into the obs.

WDYT?

https://gymnasium.farama.org/tutorials/gymnasium_basics/implementing_custom_wrappers/#inheriting-from-gymnasium-wrapper

Originally posted by @garymm in #86 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant