Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid patching Devise controllers #59

Open
zedtux opened this issue Jan 18, 2018 · 0 comments
Open

Avoid patching Devise controllers #59

zedtux opened this issue Jan 18, 2018 · 0 comments

Comments

@zedtux
Copy link

zedtux commented Jan 18, 2018

I'm using this gem with the devise_fido_usf gem in order to allow my user to chose a different 2FA option.

The expected workflow would be:

  1. Is Google Authenticator enabled? => No
  2. Is Fido U2F enabled? => No
  3. Redirect to the page to select the option

Then

  1. Is Google Authenticator enabled? => Yes
  2. Redirect to the check GA page

But as this gem is patching the Devise::SessionsController create action it is not possible to do it.

This gem should use the Warden::Manager.after_authentication callback in order to execute its code instead which would allow the above described workflow.
zedtux added a commit to Pharmony/devise_gauth that referenced this issue Jan 19, 2018
@zedtux
Stops overriding Devise::SessionsController create action (Closes Ast…
ce78f93 
…eriskLabs#59)

This commit replaces the overriding of the \`Devise::SessionsController\` creation action by the usage of a \`Warden::Manager.after_authentication\`.
zedtux added a commit to Pharmony/devise_gauth that referenced this issue Jan 19, 2018
@zedtux
Stops overriding Devise::SessionsController create action (Closes Ast…
d3a76ee 
…eriskLabs#59)

This commit replaces the overriding of the \`Devise::SessionsController\` creation action by the usage of a \`Warden::Manager.after_authentication\`.
zedtux added a commit to Pharmony/devise_gauth that referenced this issue Jan 19, 2018
@zedtux
Stops overriding Devise::SessionsController create action (Closes Ast…
8594d5a 
…eriskLabs#59)

This commit replaces the overriding of the \`Devise::SessionsController\` creation action by the usage of a \`Warden::Manager.after_authentication\`.
zedtux added a commit to Pharmony/devise_gauth that referenced this issue Jan 19, 2018
@zedtux
Stops overriding Devise::SessionsController create action (Closes Ast…
3adb077 
…eriskLabs#59)

This commit replaces the overriding of the \`Devise::SessionsController\` creation action by the usage of a \`Warden::Manager.after_authentication\`.
zedtux added a commit to Pharmony/devise_gauth that referenced this issue Jul 26, 2022
@zedtux
Stops overriding Devise::SessionsController create action (Closes Ast…
ef9c045 
…eriskLabs#59)

This commit replaces the overriding of the \`Devise::SessionsController\` creation action by the usage of a \`Warden::Manager.after_authentication\`.
zedtux added a commit to Pharmony/devise_gauth that referenced this issue Jul 26, 2022
@zedtux
Stops overriding Devise::SessionsController create action (Closes Ast…
10697a4 
…eriskLabs#59) (#4)

This commit replaces the overriding of the \`Devise::SessionsController\` creation action by the usage of a \`Warden::Manager.after_authentication\`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zedtux