Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

single swapd RPC client for both ws and http APIs #353

Open
dimalinux opened this issue Mar 20, 2023 · 0 comments
Open

single swapd RPC client for both ws and http APIs #353

dimalinux opened this issue Mar 20, 2023 · 0 comments
Labels
enhancement New feature or request p2 medium priority

Comments

@dimalinux
Copy link
Collaborator

It's a usability burden to create 2 separate clients to talk to the same server. We should just have one client that gives access to whole swapd RPC/WS API. Currently, we are dialing in NewWsClient, but I think each *Subscribe method should be creating their own websocket connection instead.

@dimalinux dimalinux added the enhancement New feature or request label Mar 20, 2023
@noot noot added the p2 medium priority label Mar 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request p2 medium priority
Projects
None yet
Development

No branches or pull requests

2 participants