Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve UX of swap_cancel and test more #373

Open
noot opened this issue Apr 5, 2023 · 0 comments
Open

improve UX of swap_cancel and test more #373

noot opened this issue Apr 5, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request p2 medium priority

Comments

@noot
Copy link
Collaborator

noot commented Apr 5, 2023

swap_cancel queues an ExitEvent, however it doesn't return the resulting exit state, so the user would need to get the swap status another way. Also, this function looks like it's hanging while attempting to exit. It would be good for this function to return updates on what's happening/what's expected to happen based on the current status, as well as the eventual exit status.

It might also be nice to make this non-blocking, and have another function to get the status/result of the cancellation?

Additionally, this needs to be tested more.

@noot noot added enhancement New feature or request p2 medium priority labels Apr 5, 2023
@noot noot self-assigned this Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request p2 medium priority
Projects
None yet
Development

No branches or pull requests

1 participant