Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Questions about the window-major feature map organization #32

Open
jacksonsc007 opened this issue Nov 7, 2024 · 1 comment
Open

Questions about the window-major feature map organization #32

jacksonsc007 opened this issue Nov 7, 2024 · 1 comment

Comments

@jacksonsc007
Copy link

I was deeply impressed by the window-major feature map organization proposed in the paper and I checked the implementation.

However, It seems that Pytorch does the window-major feature map organization automatically for us when we want to perform window attention (through the copy and re-organization built in the reshape function for non-contiguous tensor) and I could not come up with a way to calculate window attention with row-major feature map organization.

What I want is to write a code to make clear efficiency comparison between these two organization schemes. Is there any code available? Or any suggestion?

@jacksonsc007
Copy link
Author

jacksonsc007 commented Nov 8, 2024

I checked the code of VitDet and I think I kind of figure it out.

row-major

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant