Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem coming up with a hostname #722

Open
Ivanov305 opened this issue Jan 3, 2024 · 3 comments
Open

Problem coming up with a hostname #722

Ivanov305 opened this issue Jan 3, 2024 · 3 comments

Comments

@Ivanov305
Copy link

Hello.
I have a problem with some servers I am adding them to my tracker. Not all show the name, map and players in the server . I tried by adding a query port for a moment it showed the full information, but after a while the information disappeared again.
It only does it with cs 1.6
I don't have this problem with other games.
Where can this problem come from?

@Kurounin
Copy link

Kurounin commented Feb 4, 2024

The issue seems to be from src/GameQ/Protocols/Source.php. Removing the %s from:

        self::PACKET_DETAILS   => "\xFF\xFF\xFF\xFFTSource Engine Query\x00%s",

changing it into

        self::PACKET_DETAILS   => "\xFF\xFF\xFF\xFFTSource Engine Query\x00",

seems to solve this issue, but I don't know how it might affect other source games.

@lexzor
Copy link

lexzor commented Jan 11, 2025

Hello,

I reconfirm this problem in 2025. It seems @Kurounin solution works.

I would create a PR for this, but i see there are also 2 packets which has %s. Why?

self::PACKET_PLAYERS => "\xFF\xFF\xFF\xFF\x55%s", self::PACKET_RULES => "\xFF\xFF\xFF\xFF\x56%s",

EDIT: This will fix the problem for CS 1.6, but the packets won't work for CS2

@lexzor
Copy link

lexzor commented Feb 8, 2025

Any fix for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants