Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debugged datatype, logging and missing ID handling #22

Merged
merged 9 commits into from
Oct 2, 2024
Merged

Conversation

tclose
Copy link
Contributor

@tclose tclose commented Oct 1, 2024

  • fixed specification of non-DICOM datatypes
  • hashes of single files include file path
  • handles case where no loggers are specified
  • handles missing IDs gracefully by pushing to INVALID directory

Copy link

codecov bot commented Oct 2, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 4 lines in your changes missing coverage. Please review.

Project coverage is 78.60%. Comparing base (68ddb1a) to head (9bd2c84).
Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
xnat_ingest/session.py 75.00% 2 Missing ⚠️
xnat_ingest/cli/stage.py 83.33% 1 Missing ⚠️
xnat_ingest/utils.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #22      +/-   ##
==========================================
- Coverage   78.65%   78.60%   -0.06%     
==========================================
  Files          16       16              
  Lines        1279     1290      +11     
==========================================
+ Hits         1006     1014       +8     
- Misses        273      276       +3     
Flag Coverage Δ
?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tclose tclose merged commit e0d753a into main Oct 2, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant