Customer Not Enabled - If more than 25% of customers fail, the whole job should fail #22
Labels
enhancement
New feature or request
Comments
guilherme-maioli
pushed a commit
to dadosfera/tap-googleads
that referenced
this issue
Dec 11, 2024
* Store bookmarks with only a midnight time value * Add Changelog * Cleanup bookmarks test * increase no-output timeout * address feedback in PR * Add retry logic (AutoIDM#22) * Add retry logic to the search queries Reference code https://github.com/googleads/google-ads-python/blob/7ee4523d76a159f072541146339e7cb2721a3054/examples/misc/set_custom_client_timeouts.py#L106-L125 * Add error retry and log failed query on exception * fix bookmarks test * Remove selected fields log lines * Silence google's error logging * Prevent backoff from logging google's verbose errors * Deduplicate log critical lines, remove unnecessary error logging * Whitespace clean up * Make pylint happy * Fix field exclusion Metrics and segments are the only fields that have exclusions, but those exclusions can include attributes. And because we have the logic to prefer using the root resource name when checking for `selectable_with`, we don't need to worry about filtering out resources. * Rename `adgroup` to `ad_group` and `audience_performance_report` to `ad_group_audience_performance_report`. Add `campaign_audience_performance_report` * Remove comments * Bump to v0.1.0, update changelog * Update tests to expect new streams * Remove audience_performance_report, update comments * Exclude `ad_group_audience_performance_report` from tests * Renaming streams in discovery test * Making tests happy w/ new stream names * More test stream renaming. Rename confusing Class name to be accurate. * Attempt to catch another Google Internal Error * Make attribute exclusions mutual b/c bidding_strategy * Link PR in Changelog Co-authored-by: dylan-stitch <[email protected]> Co-authored-by: kspeer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
https://github.com/AutoIDM/tap-googleads/blob/main/tap_googleads/client.py#L93
Right now we just warn if we get this issue, but if more than 25% of customers have this failure we should really fail the whole tap.
The text was updated successfully, but these errors were encountered: