Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experimentalist Consistency #585

Open
chadcwilliams opened this issue Nov 30, 2023 · 1 comment
Open

Experimentalist Consistency #585

chadcwilliams opened this issue Nov 30, 2023 · 1 comment
Labels
priority 1 - needed These are highly desirable to be fixed, ideally within 2 weeks.

Comments

@chadcwilliams
Copy link
Collaborator

There is still some variations between the experimentalists, especially with what they return. Most of them (maybe all except the assumption experimentalist, which needs updating) will return a pandas DF when given conditions as a pandas DF. But the behaviour varies when providing conditions as a numpy array. For example, when getting an np.array as input, the novelty sampler outputs a pandas DF, but the falsification sampler outputs a np.array. In the tutorial we explicitly state that experimentalists MUST output a pd.DF, and I think we should adapt the experimentalists to do this no matter the input. You'll notice in the first 2 basic tutorials that there are discrepancies in the code when dealing with different experimentalists because of this and it is confusing.

@chadcwilliams chadcwilliams added the priority 2 - wanted These should be addressed within 2 months. label Nov 30, 2023
@chadcwilliams
Copy link
Collaborator Author

Let's highlight this problem in the tutorials. i.e., rely on pandas arrays, especially as outputs but in general.

@musslick musslick added priority 1 - needed These are highly desirable to be fixed, ideally within 2 weeks. and removed priority 2 - wanted These should be addressed within 2 months. labels Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority 1 - needed These are highly desirable to be fixed, ideally within 2 weeks.
Projects
None yet
Development

No branches or pull requests

2 participants