-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wp_link_pages should not be inside entry-content #1294
Comments
This has been so since the initial commit. @dshanske Where would you place |
In the entry footer function is my suggestion. It is not content, it is navigation. I know it has been where it is for a long time, but it is still not content. |
The length of time it has been there is why I started the issue to discuss. |
Sorry I was not verbose enough. 😞 I wanted to document the fact in the issue so that future me would could just read the comment without having to find the commit again. As it was part of the initial commit means that there are no issues or pull requests with reasoning why it should be added within I have been looking for examples in the wild that place I have been playing around with the idea and I am not fully convinced. I see I don't see |
My 2¢ is that
If not a EDIT I'm making the assumption of a |
Everyone puts it in the content, because it's always been there but from a structured data perspective, it arguably belongs outside the content block. I'd argue based purely on semantics it belongs in the footer, as a nav element. also, |
@grappler I don't know if linking to other starter themes is a no-no (if it is I apologize), but Sage 9 puts
|
Not that I use this particular theme, but I thought I'd chime in here since I came across this topic.
The Depending on the theme design, where to place the call is going to change. I don't see enough reason to break from convention here. |
that's what the |
wp_link_pages should not be inside entry-content, as this is not content.
The text was updated successfully, but these errors were encountered: