Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Add labels to fields in JP forms that are valid under WCAG 2.x (a11y) #35356

Closed
mjaragon opened this issue Jan 31, 2024 · 3 comments
Assignees
Labels
[Feature] Contact Form [Focus] Accessibility Improving usability for all users (a11y) [Package] Forms [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] Normal [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it

Comments

@mjaragon
Copy link

Impacted plugin

Jetpack

What

JP-forms fields should have a label that passes WCAG 2.x a11y tests

How

During our A11y tests for a contact form, using different A11y testing tools and the screen reader.
All the different tools we tested, provided the same error related to the Form label is missing on the message text area. (the text area is a Multi-line Text Field)

(see all screenshots & screen recordings in the original issue: https://github.com/a8cteam51/mckenna-academy/issues/97#issuecomment-1819092034 )

The suggestion we received from the tools was: "For more information on how to solve the issue please visit this link"

When we tested the form with a screen reader, the reader declares all the details about the other fields (Name & Email), but in the message section it only reads out the text area is required.

How can we ensure that the contact forms pass all WCAG 2.x a11y tests?

@mjaragon mjaragon added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Focus] Accessibility Improving usability for all users (a11y) [Package] Forms labels Jan 31, 2024
@github-actions github-actions bot added the [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ label Jan 31, 2024
@jeherve
Copy link
Member

jeherve commented Jan 31, 2024

@monsieur-z Do you think you could take a look at this, given your recent work on a11y for forms in #33853?

Thank you!

@monsieur-z
Copy link
Contributor

Thanks for reporting this @mjaragon.

I don't have access to the issue you shared. Can you provide more information about how the page was built and how the form is used? For instance, does the page use a Contact Form block? Is a label present in the editor that seems related to the text area?
Also, what combination of screen reader and browser was used?

Spinning up a brand new site and adding the Contact Form block as is to a page, everything seems in order. The text area and label are programmatically associated, and the screen reader (VoiceOver/Chrome) reads the label when the input receives focus.
Screenshot 2024-01-31 at 9 31 11 AM
Screenshot 2024-01-31 at 9 31 28 AM

@jeherve jeherve added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Feb 1, 2024
@jeherve
Copy link
Member

jeherve commented Feb 27, 2024

Closing this for now because of the lack of activity on this. We can always reopen in the future if needed.

@jeherve jeherve closed this as completed Feb 27, 2024
@github-actions github-actions bot removed the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Contact Form [Focus] Accessibility Improving usability for all users (a11y) [Package] Forms [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] Normal [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

No branches or pull requests

3 participants