-
Notifications
You must be signed in to change notification settings - Fork 802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Social Logos: Add post-build tests #38224
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think #37799 probably already cleaned up most of the possibilities for errors by making the various scripts actually fail if something goes wrong.
This PR has been marked as stale. This happened because:
If this PR is still useful, please do a [trunk merge or rebase](https://github.com/Automattic/jetpack/blob/trunk/docs/git-workflow.md#keeping-your-branch-up-to-date) and otherwise make sure it's up to date and has clear testing instructions. You may also want to ping possible reviewers in case they've forgotten about it. Please close this PR if you think it's not valid anymore — if you do, please add a brief explanation. If the PR is not updated (or at least commented on) in another month, it will be automatically closed. |
I don't really care about the specifics of most of the tests (other than exit code 2); mostly I wanted to decouple tests from the build process, and figured I'd add a few simple tests in the meantime. Happy to remove any deemed pointless! |
e677062
to
dee7678
Compare
Rebased. |
dee7678
to
80f9ca5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's do it
This moves the existing test out of the build script and adds a few more rudimentary post-build tests. This will help prevent silent errors from resulting in a broken build (e.g. regressions discovered/fixed in #37799).
As written, it runs as part of
composer build-production
. Feel free to adapt as desired.Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions:
Run
composer build-production
and verify it works as expected.