Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protect: My Jetpack Card is Misleading on Pressable #38970

Closed
bobmatyas opened this issue Aug 20, 2024 · 1 comment · Fixed by #40880
Closed

Protect: My Jetpack Card is Misleading on Pressable #38970

bobmatyas opened this issue Aug 20, 2024 · 1 comment · Fixed by #40880
Assignees
Labels
[Package] My Jetpack [Plugin] Protect A plugin with features to protect a site: brute force protection, security scanning, and a WAF. [Pri] Normal [Status] Priority Review Triggered The guild in charge of triage has been notified of this issue in Slack Triaged [Type] Bug When a feature is broken and / or not performing as intended

Comments

@bobmatyas
Copy link
Contributor

Impacted plugin

Protect

Quick summary

On Pressable and WordPress.com, the Jetpack Protect card in "My Jetpack" says that Auto-firewall is disabled and implies that it is user configurable. However, users can't turn on the feature on the hosts

Steps to reproduce

  1. Add a Jetpack Scan plan to a site hosted on Pressable
  2. View the My Jetpack Protect card and see that the auto-firewall is grayed out

A clear and concise description of what you expected to happen.

I think that ideally we should communicate that the firewall is turned off / unnecessary on this particular host. I think it should be mentioned on both the card and in the plugin setting so that it isn't confusing if users can't find the setting.

What actually happened

My Jetpack:

Annotation on 2024-08-20 at 08-35-11

Tooltip on My Jetpack implies it is user configurable:

Screenshot on 2024-08-20 at 08-35-28

Firewall settings:

Annotation on 2024-08-20 at 08-36-37

Impact

All

Available workarounds?

No but the platform is still usable

If the above answer is "Yes...", outline the workaround.

No response

Platform (Simple and/or Atomic)

No response

Logs or notes

No response

@bobmatyas bobmatyas added [Type] Bug When a feature is broken and / or not performing as intended [Package] My Jetpack [Plugin] Protect A plugin with features to protect a site: brute force protection, security scanning, and a WAF. Needs triage Ticket needs to be triaged labels Aug 20, 2024
@github-actions github-actions bot added [Status] Priority Review Triggered The guild in charge of triage has been notified of this issue in Slack [Pri] High labels Aug 20, 2024
@bobmatyas bobmatyas added Triaged and removed Needs triage Ticket needs to be triaged labels Aug 20, 2024
@bobmatyas bobmatyas moved this from Needs Triage to Triaged in Automattic Prioritization: The One Board ™ Aug 20, 2024
@CodeyGuyDylan
Copy link
Contributor

I opened a PR for this, I just added a new Tooltip for the Protect card in My Jetpack that explains WAF is unsupported for their site and why. I think this solves all the issues brought up here but let me know if I am wrong

@CodeyGuyDylan CodeyGuyDylan self-assigned this Jan 7, 2025
@CodeyGuyDylan CodeyGuyDylan linked a pull request Jan 8, 2025 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] My Jetpack [Plugin] Protect A plugin with features to protect a site: brute force protection, security scanning, and a WAF. [Pri] Normal [Status] Priority Review Triggered The guild in charge of triage has been notified of this issue in Slack Triaged [Type] Bug When a feature is broken and / or not performing as intended
Development

Successfully merging a pull request may close this issue.

2 participants