Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WordPress 6.7 compatibility: Add __nextHasNoMarginBottom to remaining BaseControl based components #39823

Closed
Tracked by #38902
coder-karen opened this issue Oct 18, 2024 · 0 comments · Fixed by #39877
Assignees
Labels
[Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Type] Task

Comments

@coder-karen
Copy link
Contributor

coder-karen commented Oct 18, 2024

In WordPress 6.7, deprecation notices will start to be logged for BaseControl-based components.

We need to check all use-cases of these components in the Jetpack monorepo and apply __nextHasNoMarginBottom.
Technically we don't need to opt in to the new margin-free styles, but since the margins will be removed in a later release (and deprecation notices logged until then), it would be worth checking these instances to see if there are any display discrepancies as well.

An initial effort was done here: #39176. As a current example, when adding a VideoPress block and uploading a video there are two, related to wp.components.ToggleControl and wp.components.RangeControl:

Bottom margin styles for wp.components.ToggleControl is deprecated since version 6.7 and will be removed in version 7.0. Note: Set the `__nextHasNoMarginBottom` prop to true to start opting into the new styles, which will become the default in a future version.
Bottom margin styles for wp.components.RangeControl is deprecated since version 6.7 and will be removed in version 7.0. Note: Set the `__nextHasNoMarginBottom` prop to true to start opting into the new styles, which will become the default in a future version.

Script debug does need to be enabled in wp-config.php: define( 'SCRIPT_DEBUG', true ); though (and at the moment, WordPress 6.7 on a test site using the WordPress Beta Tester plugin).

More info: https://make.wordpress.org/core/2024/10/18/editor-components-updates-in-wordpress-6-7/#bottom-margin-styles-are-deprecated-39358

@coder-karen coder-karen self-assigned this Oct 18, 2024
@jeherve jeherve added [Type] Task [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ labels Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Type] Task
Projects
None yet
2 participants