Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jetpack comments no longer show "Like" information upon hover, for Atomic sites #39906

Open
desnum opened this issue Oct 25, 2024 · 2 comments
Open
Labels
Customer Report Issues or PRs that were reported via Happiness. aka "Happiness Request", or "User Report" [Feature] Comment Likes [Focus] Compatibility Ensuring our products play well with third-parties [Pri] Low Simple/Atomic Parity Triaged [Type] Bug When a feature is broken and / or not performing as intended

Comments

@desnum
Copy link

desnum commented Oct 25, 2024

Quick summary

The "Likes" on comments (not on the post, but specifically on the comments) show a Like count, but when you hover over that count, it does not show who left those likes on the comment. This issue is specific to AT sites.

Steps to reproduce

Create a WordPress site on a Business plan or higher.
Ensure hosting features are activated.
Enable the Jetpack comments module via /wp-admin/admin.php?page=jetpack_modules.
Open any post and submit a comment.
Like the comment.
You should be able to hover over the Like count to see who liked the comment, like this example from a simple site:

Image

What actually happened

Nothing pops up when you hover over the Like count, and the Like count links to https://widgets.wp.com/likes/#

Image

Impact

All Atomic sites

Available workarounds?

Not completely: notifications will show who liked your own comments, but not who liked other people's comments on your posts.

Platform (Simple and/or Atomic)

Atomic

Logs or notes

The issue is not reproducible on simple WordPress.com sites.

@desnum desnum added [Feature] Comments Customer Report Issues or PRs that were reported via Happiness. aka "Happiness Request", or "User Report" Simple/Atomic Parity labels Oct 25, 2024
@jeherve
Copy link
Member

jeherve commented Oct 28, 2024

@ivan-ottinger Tagging you on this one. Can you think of changes the Apex team would have made in the past year that would explain this discrepancy between WoA and self-hosted?

@jeherve jeherve added [Type] Bug When a feature is broken and / or not performing as intended [Pri] Low [Focus] Compatibility Ensuring our products play well with third-parties labels Oct 28, 2024
@jeherve jeherve moved this from Needs Triage to Triaged in Automattic Prioritization: The One Board ™ Oct 28, 2024
@ivan-ottinger
Copy link
Contributor

Thank you for the ping, Jeremy! I was AFK so replying just today.


Can you think of changes the Apex team would have made in the past year that would explain this discrepancy between WoA and self-hosted?

I don't think this issue is related to any recent changes. Looking at the code that renders comment likes, Simple sites rely on different logic than Atomic sites.

To be more specific, here's an example of the comment-content div of Simple vs Atomic site:

Simple:

Image

Core logic lives in comment-likes.js (fbhepr%2Skers%2Sjcpbz%2Sjc%2Qpbagrag%2Szh%2Qcyhtvaf%2Spbzzrag%2Qyvxrf%2Swf%2Spbzzrag%2Qyvxrf.wf%3Se%3Q72990n33-og).

Atomic:

Image

Core logic lives in likes-rest-nojquery.js (fbhepr%2Skers%2Sjcpbz%2Sjc%2Qpbagrag%2Swf%2Syvxrf%2Qerfg%2Qabwdhrel.wf%3Se%3Qn19948p7-og).


The JavaScript code that Simple sites are using has two event listeners that handle the display of the "comment likers box" on mouseenter / mouseleave events (code link: fbhepr%2Skers%2Sjcpbz%2Sjc%2Qpbagrag%2Szh%2Qcyhtvaf%2Spbzzrag%2Qyvxrf%2Swf%2Spbzzrag%2Qyvxrf.wf%3Se%3Q72990n33%23641%2Q739-og). This (and related) logic is not available to Atomic sites and hence the list of likers doesn't load on hover.

Other differences can be also observed in the copy styling and where the anchor / link is placed (on Atomic sites, the whole copy is one anchor / link).


After looking through the related code, I would say that untangling the comment likes disparity between Simple and Atomic requires more time and effort than a simple bug fix. Because of that, I am tagging this issue as Needs shaping.

@ivan-ottinger ivan-ottinger moved this from Triaged to Needs shaping in Automattic Prioritization: The One Board ™ Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Customer Report Issues or PRs that were reported via Happiness. aka "Happiness Request", or "User Report" [Feature] Comment Likes [Focus] Compatibility Ensuring our products play well with third-parties [Pri] Low Simple/Atomic Parity Triaged [Type] Bug When a feature is broken and / or not performing as intended
Projects
Development

No branches or pull requests

3 participants