Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor wpcomsh_make_content_clickable #40134

Open
renatho opened this issue Nov 11, 2024 · 0 comments
Open

Refactor wpcomsh_make_content_clickable #40134

renatho opened this issue Nov 11, 2024 · 0 comments
Labels
[Plugin] Wpcomsh [Type] Task

Comments

@renatho
Copy link
Contributor

renatho commented Nov 11, 2024 •
edited
Loading

This is a follow-up of this discussion.

The idea is to refactor the function wpcomsh_make_content_clickable to use WP HTML API. When it was written, we didn't have this, so it's a complex function with regexes and loops checking strings.

As we identified in that PR, it's prone to errors.
@renatho renatho changed the title Refactor wpcomsh_make_content_clickable Refactor wpcomsh_make_content_clickable Nov 11, 2024
@renatho renatho mentioned this issue Nov 11, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Plugin] Wpcomsh [Type] Task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jeherve @renatho