Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map block: Update “Show fullscreen button” toggle to “Show controls” and enhance functionality #40717

Open
richtabor opened this issue Dec 21, 2024 · 2 comments
Labels
[Block] Map [Experiment] AI labels added [Feature Group] Editor Experience Features related to Gutenberg integration on WordPress.com. [Feature] Maps [Feature] WordPress.com Block Editor [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it

Comments

@richtabor
Copy link

Description:

The toggle labeled “Show fullscreen button” should be renamed to “Show controls”. The help text can be removed; it's duplicative.

Additionally, it should be updated to hide or show all map controls, not just the fullscreen button.

Steps to Reproduce:

  1. Add a map block to the editor.
  2. Locate the “Show fullscreen button” toggle in the block settings.
  3. Toggle it on and off, observing that it only affects the fullscreen button.

Expected:

• The toggle is renamed to “Show controls.”
• Toggling it on/off should show or hide all controls possible on the map.

Actual:

• The toggle is labeled “Show fullscreen button” and only controls the visibility of the fullscreen button.

Visual:
Image

@richtabor richtabor added [Block] Map [Type] Bug When a feature is broken and / or not performing as intended [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it and removed [Type] Bug When a feature is broken and / or not performing as intended labels Dec 21, 2024
@richtabor
Copy link
Author

Note the casing in "Show controls" is intentional (we should not use title case for controls).

@github-actions github-actions bot added [Feature Group] Editor Experience Features related to Gutenberg integration on WordPress.com. [Feature] Maps [Feature] WordPress.com Block Editor labels Dec 21, 2024
Copy link
Contributor

OpenAI suggested the following labels for this issue:

  • [Feature Group] Editor Experience: The issue refers to the block editor where the toggle functionality is being modified.
  • [Feature] Maps: The issue specifically addresses functionality related to the map block and its controls.
  • [Feature] WordPress.com Block Editor: The toggle settings discussed relate directly to the WordPress block editor experience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Map [Experiment] AI labels added [Feature Group] Editor Experience Features related to Gutenberg integration on WordPress.com. [Feature] Maps [Feature] WordPress.com Block Editor [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

No branches or pull requests

1 participant