Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twenty Seventeen: Front Page Panel Images Incorrectly Zoomed on iPad OS #1421

Closed
edequalsawesome opened this issue Sep 24, 2019 · 28 comments
Closed
Labels
Customer Report Issues or PRs that were reported via Happiness. aka "Happiness Request", or "User Report". [Interaction #] > 10 (Automated) interaction count label for better visibility. Please don't add these manualliy. [Pri] Low [Status] Core fix needed This issues is coming from a bundled theme (Twenty Something)) core and is being addressed in trac. Support [Theme] Twenty Seventeen Triaged [Type] Bug Something isn't working

Comments

@edequalsawesome
Copy link

Steps to replicate

Set up the front page of a site using Twenty Seventeen with panels that show pages with featured images.

Result

The featured images will be zoomed in on iPad OS, but will work elsewhere:

Panel Image Zoomed In

Expected

The featured image will be displayed at a size that will allow the image to be shown correctly:

Panel Image Displayed Correctly

  • User report: #14006590-hc
  • Follow-up ticket: #2376264-zen

Provided the customer with the following CSS to resolve the issue, although that removes the parallax effect from all browser types:

/* resolve issues with background positioning */
.background-fixed .panel-image {
	background-attachment: unset;
}
@edequalsawesome edequalsawesome added [Type] Bug Something isn't working Support labels Sep 24, 2019
@edequalsawesome edequalsawesome added this to the Twenty Seventeen milestone Sep 24, 2019
@wazmac
Copy link

wazmac commented Sep 25, 2019

Similar issues here.

Example pages:
elementsofhyams.com
compactrv.net
kiamacycles.com.au

The only devices affected are those running iPadOS 13.1

Web pages display OK on desktops, laptops, on iPads running earlier versions of iOS, and on iPhones with iOS 13.1 installed.

Warren

@wazmac
Copy link

wazmac commented Sep 29, 2019

An update on this issue....

The same websites - WordPress sites that don't display correctly using Safari on iPadOS - display just fine using the Chrome browser app on iPadOS.

I have posted some screen shots and more details at http://bit.ly/2lCEIxp

Warren

@wazmac
Copy link

wazmac commented Oct 19, 2019

Further note on this issue - if the mobile version of the site is loaded in Safari on iPadOS, the images display OK, albeit without the parallax effect.

I have updated the previous notes with screenshots, etc, at http://bit.ly/2nvx7kT

@thebud15
Copy link

Reported in 2433948-zd

@Robertght
Copy link

I can confirm this to be an issue with Lodestar as well - it looks more like a general issue on iOS and background images being fixed.

@eduardozulian
Copy link
Member

Reported in 2520933-zen

@nunyvega
Copy link
Contributor

nunyvega commented Dec 2, 2019

Reported in 2531839-zen and 2532347-zen

@katiebethbrown
Copy link

katiebethbrown commented Oct 12, 2020

Another report in 7933545-hc

User requested to be notified when a fix is in place. I set expectations.

@dcoleonline
Copy link

Another report in 4136047-zd

@kosiew
Copy link

kosiew commented Sep 4, 2021

Another report in #4261626-zen

@nicolynramos
Copy link

Another report here: 4361861-zd
I was able to reproduce on testsep16.wordpress.com on iPad Air 4th gen on OS 15.1

@cuemarie
Copy link

cuemarie commented Oct 8, 2021

Another report here: 4361861-zd I was able to reproduce on testsep16.wordpress.com on iPad Air 4th gen on OS 15.1

Just following up as user replied; they'd like to be notified when a fix is in place. @nicolynramos set expectations. 👍 Closing this ticket.

@dcoleonline
Copy link

4554952-zen
I recommended that they switch to a newer theme

I was able to replicate this on a 7th gen iPad with iPad iOS 14.8

This happened both on the demo site and the customer's site

@mrfoxtalbot
Copy link

This issue is affecting a bundled (default) theme has already been reported in trac:
https://core.trac.wordpress.org/ticket/48195

I am going to close this issue in favor of the one in trac.

@mrfoxtalbot
Copy link

I am reopening this. After some discussion with the themes team, we are going to tag this type of issue as [Status] Core fix needed but leave them open for tracking and discoverability purposes.

@mrfoxtalbot mrfoxtalbot reopened this Jun 17, 2022
@mrfoxtalbot mrfoxtalbot added the [Status] Core fix needed This issues is coming from a bundled theme (Twenty Something)) core and is being addressed in trac. label Jun 17, 2022
@rickmgithub
Copy link

It looks like this issue remains a problem. A new report which we can replicate on our end with the 2017 theme.

5774675-zd

@github-actions
Copy link
Contributor

github-actions bot commented Dec 12, 2022

Support References

This comment is automatically generated. Please do not edit it.

  • 2376264-zen
  • 2433948-zen
  • 2520933-zen
  • 2531839-zen
  • 2532347-zen
  • 4136047-zen
  • 4261626-zen
  • 4361861-zen
  • 4554952-zen
  • 5774675-zen
  • 8473493-zen

@mrfoxtalbot
Copy link

I was looking at the Trac issue and it appears as "Closed/Fixed" there 🤔

I did a quick test and I cannot reproduce this anymore.
Screen Shot on 2022-12-15 at 12:58:35

@rickmgithub, were you able to reproduce this yourself on the site that reported the issue? Thank you!

@upwardmomentum84
Copy link

Another case here: 40670185-hc

Site is on Personal plan so no CSS.

@mrfoxtalbot
Copy link

The trac issue is solved, so this should be solved in dotcom too.

I see that the dotorg version is on Version 3.2 but dotcom's is Version is 3.2-wpcom, maybe this is what's causing the inconsistency, @jeffikus ?

@mxhassani
Copy link

The issue is still standing: 8473493-zen

@github-actions github-actions bot added [Interaction #] > 10 (Automated) interaction count label for better visibility. Please don't add these manualliy. Customer Report Issues or PRs that were reported via Happiness. aka "Happiness Request", or "User Report". labels Jul 23, 2024
@mrfoxtalbot
Copy link

I see @jeffikus is no longer working on themes.

@dsas, I am not sure if you are still working on themes, do you know who owns keeping dotcom themes up to date?

Thank you!

@dsas
Copy link
Contributor

dsas commented Aug 20, 2024

do you know who owns keeping dotcom themes up to date?

It's been a bit of a grey area, but I guess it's now a Marvel responsibility to be handled by the theme supersquad (currently myself, @miksansegundo and @alaczek). We get to spend some of our time on theme maintenance issues

@mrfoxtalbot
Copy link

theme supersquad

I love the name :D

It'd be good to review bundled themes to ensure dotcom is using the latest version.

Thanks again!

@dsas
Copy link
Contributor

dsas commented Aug 20, 2024

We have the code mentioned in the patch applied already on dotcom.

I can't repro when using a simulated ipad on either a fresh install or viewing the site in 40670185-hc Can anyone reproduce this and write some reproduction steps for me? CC @upwardmomentum84

The issue is still standing: 8473493-zd-a8c

The user was using Twenty-Twenty rather than Twenty-Seventeen so that sounds like a different bug @mxhassani

@miksansegundo
Copy link
Contributor

I also cannot reproduce this issue when using an up-to-date Safari browser on iPhone and iPad.

Tested on my own test site and viewing the site in 40670185-hc

I believe this is another issue like Automattic/wp-calypso#87158 and Automattic/wp-calypso#87290 that only affect old Safari browsers.

If someone can reproduce it, please indicate the Safari or iOS version, and share the site.

@eduardozulian
Copy link
Member

eduardozulian commented Aug 21, 2024

I also can't reproduce it anymore using an iPad Air 2014. Based on the above, I'd vote for closing this one (cc @mrfoxtalbot)

@wazmac
Copy link

wazmac commented Aug 21, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Customer Report Issues or PRs that were reported via Happiness. aka "Happiness Request", or "User Report". [Interaction #] > 10 (Automated) interaction count label for better visibility. Please don't add these manualliy. [Pri] Low [Status] Core fix needed This issues is coming from a bundled theme (Twenty Something)) core and is being addressed in trac. Support [Theme] Twenty Seventeen Triaged [Type] Bug Something isn't working
Projects
Development

No branches or pull requests