Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHPDocs and Typehints #41

Open
tomjn opened this issue Jul 27, 2023 · 2 comments
Open

PHPDocs and Typehints #41

tomjn opened this issue Jul 27, 2023 · 2 comments
Assignees
@ingeniumed @smithjw1 @alecgeatches
Labels
bug Something isn't working

Comments

@tomjn
Copy link

tomjn commented Jul 27, 2023 •
edited
Loading

Describe the bug

There's almost no type hinting in the plugin, and half the methods are missing PHPDocs.

To Reproduce

look at the code, I would have expected the VIP PHPCS rules to have flagged the missing PHPDocs, or WPCS. PHStan should be kicking up a fuss about it too

Version of the plugin
1.0.1
@tomjn tomjn added the bug Something isn't working label Jul 27, 2023
@ingeniumed
Copy link
Contributor

@tomjn Thanks for flagging this, I agree with you on getting this added in. We will work on getting this resolved 👍🏾

@ingeniumed ingeniumed mentioned this issue Aug 1, 2023
Merged
@ingeniumed ingeniumed linked a pull request Aug 1, 2023 that will close this issue
Add PHPDocs and add it to the phpcs workflow #43
Merged
@ingeniumed ingeniumed removed a link to a pull request Aug 1, 2023
Add PHPDocs and add it to the phpcs workflow #43
Merged
@alecgeatches alecgeatches mentioned this issue Aug 2, 2023
Merged
@ingeniumed
Copy link
Contributor

PHPDocs are in, type hinting is what's left to be added in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ingeniumed ingeniumed

@smithjw1 smithjw1

@alecgeatches alecgeatches

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@tomjn @ingeniumed @smithjw1 @alecgeatches