-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show backup screenshot in activity log #38620
Conversation
This is a WIP. I need to determine how to get the period parameter. Currently using the rewindId, but it doesn't seem to be the same as the period. However, the basic image retrieval from the backend and rendering is working. |
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~669 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~349 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
{ 'rewind__backup_complete_full' === activityName && ( | ||
<Image | ||
src="data:image/gif;base64,R0lGODlhAQABAAD/ACwAAAAAAQABAAACADs=" | ||
alt="Backup screenshot" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this phrase be translatable?
This issue has been marked as stale and will be closed in seven days. This happened because:
You can keep the issue open by adding a comment. If you do, please provide additional context and explain why you’d like it to remain open. You can also close the issue yourself — if you do, please add a brief explanation. |
This PR has been marked as stale due to lack of activity within the last 30 days. |
Closing this PR as the last activity was ~3.5 years ago and we are not currently planning to work on it (p1729526626502529-slack-CS8UYNPEE). |
Changes proposed in this Pull Request
Testing instructions
OPTIONAL:
Use the API console.