You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the site editor, we need to add tracking events for when a user either:
Converts the selected blocks into a Template Part
Detaches blocks from their Template Part.
This can be found in the ellipsis menu for a selection of block(s) or a template part:
A note (and ❓s ) on existing events that this triggers:
When the 'detach' happens, it currently triggers the wpcom_block_picker_block_inserted event. I believe this event should be suppressed as the block was already on the page as part of the template part and firing the event for the template part dispatch should be enough. Alternative to suppressing the event, we could look at populating the insert_method with a value such as "detach from template part".
When the 'convert' happens, the wpcom_block_picker_block_inserted event also fires for the core/template-part block. Similarly this could also be suppressed given firing a 'convert to template part' event would already convey this information. Similar alternative, we could keep that event and populate the insert_method with something like "convert to template part".
The detach/convert events could also have properties corresponding to which blocks we converted/detached, etc.
When the 'detach' happens, it currently triggers the wpcom_block_picker_block_inserted event. I believe this event should be suppressed as the block was already on the page as part of the template part and firing the event for the template part dispatch should be enough.
When the 'convert' happens, the wpcom_block_picker_block_inserted event also fires for the core/template-part block. Similarly this could also be suppressed given firing a 'convert to template part' event would already convey this information.
Agree on suppressing both of these.
The detach/convert events could also have properties corresponding to which blocks we converted/detached, etc.
This is a great idea. Happy to go with the 'flat list' approach that was suggested on #53592.
In the site editor, we need to add tracking events for when a user either:
This can be found in the ellipsis menu for a selection of block(s) or a template part:
![Screen Shot 2021-06-08 at 3 40 00 PM](https://user-images.githubusercontent.com/28742426/121247116-dd05c500-c86f-11eb-95a1-7c46bb571b98.png)
![Screen Shot 2021-06-08 at 3 40 09 PM](https://user-images.githubusercontent.com/28742426/121247156-e7c05a00-c86f-11eb-9232-da98eec8a4bb.png)
A note (and ❓s ) on existing events that this triggers:
When the 'detach' happens, it currently triggers the
wpcom_block_picker_block_inserted
event. I believe this event should be suppressed as the block was already on the page as part of the template part and firing the event for the template part dispatch should be enough. Alternative to suppressing the event, we could look at populating theinsert_method
with a value such as "detach from template part".When the 'convert' happens, the
wpcom_block_picker_block_inserted
event also fires for thecore/template-part
block. Similarly this could also be suppressed given firing a 'convert to template part' event would already convey this information. Similar alternative, we could keep that event and populate theinsert_method
with something like "convert to template part".The detach/convert events could also have properties corresponding to which blocks we converted/detached, etc.
Thoughts cc @ianstewart @kurt213 ?
Related to
#53410
The text was updated successfully, but these errors were encountered: