Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LaunchPad on atomic site preview - "Coming Soon" #73377

Closed
Addison-Stavlo opened this issue Feb 15, 2023 · 3 comments
Closed

LaunchPad on atomic site preview - "Coming Soon" #73377

Addison-Stavlo opened this issue Feb 15, 2023 · 3 comments
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Feature] Launchpad The onboarding Launchpad that guides users through setting up their site and getting it launched. [Pri] High Address as soon as possible after BLOCKER issues

Comments

@Addison-Stavlo
Copy link
Contributor

Addison-Stavlo commented Feb 15, 2023

There seems to be some regression in our coming soon bypass for atomic in the launchpad preview (previous art in #71636) . Visit the launchpad on an atomic site (business plan -> activate hello dolly plugin), after transfer visit my home and get redirected to the launchpad. Notice 'coming soon' instead of the site preview.

UPDATE: I spent several hours testing and looking at this today. To refine the above findings:

  • This issue appears to be intermittent. I created about 25-30 new test sites today, and transferred them to Atomic. I would say I saw this issue about 1 out of 4 times. The other times the web preview loaded correctly, with
    • About 3-4 times, I experienced a situation where the launchpad_screen option was false on atomic, and the site would not redirect to launchpad at all. This is a separate issue, and also appears to be intermittent.
  • This issues resolves by refreshing the launchpad screen. So when you see it, if you just refresh the page, it goes away.
  • I assume this issue is related to our use of share codes to bypass the coming soon screen on atomic. See this PR. However, I found that even when I saw the coming soon page, a share code did appear to be generated and appended to the url of the web preview. The share code value would initially be undefined, but would ultimately be populated. Despite that, the coming soon screen loaded.
  • If you start to troubleshoot the share code issue, search for is_accessed_by_valid_share_link as a starting point. You should find it the jetpack-mu-plugin under features/coming-soon.

image

Steps to reproduce

  1. Start at https://wordpress.com/start/domains and create a new site.
  2. When you get plans, choose a Business plan. On the Goals screen, chose 'Promote myself or my business'.
  3. Continue through setup until you get to first Launchpad screen.
  4. Click Skip to Dashboard, and activate any plugin. This will initiate the Atomic transfer.
  5. Once plugin is installed and atomic transfer is done, navigate to My Home. It should redirect you to launchpad.

What I expected

When you get to launchpad, the web preview should show the actual site with your theme.

What happened instead

What you will see instead - in some cases - is the coming soon screen.

@Addison-Stavlo Addison-Stavlo added [Pri] High Address as soon as possible after BLOCKER issues [Feature] Launchpad The onboarding Launchpad that guides users through setting up their site and getting it launched. labels Feb 15, 2023
@edanzer edanzer self-assigned this Feb 15, 2023
@ash1eygrace
Copy link
Member

ash1eygrace commented Aug 24, 2024

Just a note, I ran into an issue on a ping p1724499194310919-slack-C03TY6J1A. Coming Soon wasn't a factor in this case, but it all seems closely related to the launchpad setup functionality.

User ticket: 8646084-zd-a8c

When accessing WordPress.com the users site was redirecting to:

https://wordpress.com/setup/false/goals?siteSlug=USERSSITE (just a white screen)

To fix it, I manually went to the url in their account:
https://wordpress.com/setup/build/launchpad?siteSlug=USERSSITE

That seemed to break the site out of the redirect to https://wordpress.com/setup/false/goals?siteSlug=wordsatnight.com

It also, seems related to: #88384

The users's case above is fixed, but just noting this incase it helps.

Copy link

Support References

This comment is automatically generated. Please do not edit it.

  • 8646084-zen

@github-actions github-actions bot added the Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". label Aug 24, 2024
@richtabor
Copy link

This launchpad is being deprecated for an in-WordPress launchpad in #98245. I'll go ahead and close this.

@richtabor richtabor closed this as not planned Won't fix, can't repro, duplicate, stale Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Feature] Launchpad The onboarding Launchpad that guides users through setting up their site and getting it launched. [Pri] High Address as soon as possible after BLOCKER issues
Projects
None yet
Development

No branches or pull requests

4 participants