Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assembler: Remove snackbar notices on pattern selection/removal #85320

Closed
richtabor opened this issue Dec 14, 2023 · 3 comments
Closed

Assembler: Remove snackbar notices on pattern selection/removal #85320

richtabor opened this issue Dec 14, 2023 · 3 comments
Labels
[Feature] Pattern Assembler The tool for building off of blank canvas using patterns. [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it

Comments

@richtabor
Copy link

They can be distracting, and not quite helpful.

The notices are not necessary for shuffling, as you've interacted the pattern you're changing anyhow; the same for deleting a pattern. I suspect the notice is in place as you may not visually see the latest pattern added to page. If this is the case, it's not the correct affordance for that.

Instead, we should first consider scaling down the site (#85123 (comment)), so you can see more of what you're doing. And second, the site preview should always smooth-scroll to the recently applied pattern on selection (#85319).

Combined, those would add much more awareness to what's happening than a notice.

Visual

snackbars.mp4
@richtabor richtabor added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Feature] Pattern Assembler The tool for building off of blank canvas using patterns. labels Dec 14, 2023
@richtabor
Copy link
Author

richtabor commented Dec 14, 2023

The snackbar also indicates insertion when you move a pattern using the movers. 😅

@autumnfjeld
Copy link
Contributor

On shuffle it definitely is not needed.

@taipeicoder
Copy link
Contributor

Closing this as we are sunsetting the Site Assembler.

@taipeicoder taipeicoder closed this as not planned Won't fix, can't repro, duplicate, stale Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Pattern Assembler The tool for building off of blank canvas using patterns. [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

No branches or pull requests

3 participants