Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page optimize plugin causing horizontal scroll on some themes #95563

Open
simison opened this issue Oct 21, 2024 · 2 comments
Open

Page optimize plugin causing horizontal scroll on some themes #95563

simison opened this issue Oct 21, 2024 · 2 comments
Assignees
Labels
[Platform] Atomic [Pri] High Address as soon as possible after BLOCKER issues [Status] Priority Review Triggered Quality squad has been notified of this issue in #dotcom-triage-alerts Triaged To be used when issues have been triaged. [Type] Bug When a feature is broken and / or not performing as intended

Comments

@simison
Copy link
Member

simison commented Oct 21, 2024

Quick summary

Page optimize conflicts with something on a basic Atomic site, causing a big horizontal scroll to appear on multiple themes:

Steps to reproduce

  • Normal Atomic site with block theme ("bain marie" or "dark academia" for example)
  • Ensure Page optimize and it's "concat CSS" functionality is enabled (as is by default)
  • Open blog post with comments, note the scroll horizontally both mobile and desktop screens — example https://simisonatomic1.wpcomstaging.com/2019/09/04/example-post/

Image

Screen.Recording.2024-10-21.at.15.13.18.mov
  • Note how hiding navigation area in the example "solves" the issue.

  • Disabling comments (or looking at pages without comments) also solves the issue.

  • Also disabling concatenating "solves" the problem:

Likely some CSS relevant to the the navigation area or comments was relying on got loaded in wrong order because of CSS concat.

The issue didn't replicate the Classic "Mayland" theme.

What you expected to happen

No horizontal scroll on mobile.

What actually happened

Horizontal big area on mobile:

Impact

Some (< 50%)

Available workarounds?

No but the platform is still usable

If the above answer is "Yes...", outline the workaround.

No response

Platform (Simple and/or Atomic)

Atomic

Logs or notes

Reported at p1729454109701619-slack-C029GN3KD (discussion in another thread p1729454102062879-slack-C029GN3KD)

@simison simison added [Type] Bug When a feature is broken and / or not performing as intended Needs triage Ticket needs to be triaged labels Oct 21, 2024
@github-actions github-actions bot added the [Status] Priority Review Triggered Quality squad has been notified of this issue in #dotcom-triage-alerts label Oct 21, 2024
@github-actions github-actions bot added [Platform] Atomic [Pri] High Address as soon as possible after BLOCKER issues labels Oct 21, 2024
@Robertght
Copy link

📌 REPRODUCTION RESULTS

  • Tested on Simple – Could Not Replicate
  • Tested on Atomic – Replicated

📌 FINDINGS/SCREENSHOTS/VIDEO

  • I could also replicate it using Jetpack Boost, so does that mean it's a combination between the theme/gutenberg core and the optimization process or something else?

📌 ACTIONS

  • Triaged

I can see @escapemanuele is assigned so I'll mark this as triaged, but let me know if you need further hands to test this.

@Robertght Robertght added Triaged To be used when issues have been triaged. and removed Needs triage Ticket needs to be triaged labels Oct 22, 2024
@Robertght Robertght moved this from Needs Triage to Triaged in Automattic Prioritization: The One Board ™ Oct 22, 2024
@agrullon95
Copy link
Contributor

Using @simison test site (https://simisonatomic1.wpcomstaging.com/2019/09/04/example-post/), I figured out that the screen reader label for the search navigation feature is causing the width issue. It has a width:100% set, but I'm going to look further into it to see if this is a proper solution across themes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Platform] Atomic [Pri] High Address as soon as possible after BLOCKER issues [Status] Priority Review Triggered Quality squad has been notified of this issue in #dotcom-triage-alerts Triaged To be used when issues have been triaged. [Type] Bug When a feature is broken and / or not performing as intended
Projects
Development

No branches or pull requests

4 participants