Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twenty Sixteen theme does not respect letter case styling options in Buttons Block #97778

Open
pauljacobson opened this issue Dec 25, 2024 · 3 comments
Labels
Block Rendering Blocks Editor blocks, aka Gutenberg blocks, plugins, and extensions Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Feature] Core Blocks Blocks that come with Gutenberg. [Feature Group] Appearance & Themes Features related to the appearance of sites. [Feature] .Org Themes Core themes imported from the WordPress.org repository. Groundskeeping Issues handled through Dotcom Groundskeeping rotations Needs triage Ticket needs to be triaged [Platform] Simple [Pri] Normal Schedule for the next available opportuinity. [Product] WordPress.com All features accessible on and related to WordPress.com. [Type] Bug

Comments

@pauljacobson
Copy link

Quick summary

The Twenty Sixteen theme doesn't seem to respect the letter case styling option (under Typography) in the Buttons Block. It does seem to respect the styling option for regular Paragraph text, though.

Here is a demo of the issue with voiceover:

CleanShot.2024-12-25.at.12.53.07.mp4

Steps to reproduce

  1. Add a Buttons block to a post or page on a site with Twenty Sixteen enabled
  2. Add text to the button - observe that it is styled as uppercase by default
  3. Select the Button or Buttons blocks, try change the letter case option under the block's Typography styles
  4. Observe that the letter case for the button text doesn't change based on the letter case selection

What you expected to happen

The button text should change case as letter case selections are made in the block styles.

What actually happened

The letter case option is not being applied to button text.

Impact

Most (> 50%)

Available workarounds?

Yes, easy to implement

If the above answer is "Yes...", outline the workaround.

We can use Custom CSS code to disable the text-transform rule being applied to the button text, like this:

#post-1>div>div:nth-child(2)>div>div>div>a {
    text-transform: none;
}

Platform (Simple and/or Atomic)

Simple

Logs or notes

This was reported in 9209528-zen and tested on sites with a WordPress.com Personal Plan and on a free plan.

Tested on macOS 15.2 using Microsoft Edge Dev browser, v133.0.3014.0

@pauljacobson pauljacobson added [Feature Group] Appearance & Themes Features related to the appearance of sites. [Feature] .Org Themes Core themes imported from the WordPress.org repository. [Product] WordPress.com All features accessible on and related to WordPress.com. [Type] Bug Needs triage Ticket needs to be triaged labels Dec 25, 2024
@pauljacobson pauljacobson added Blocks Editor blocks, aka Gutenberg blocks, plugins, and extensions Block Rendering [Feature] Core Blocks Blocks that come with Gutenberg. and removed [Status] Auto-allocated labels Dec 25, 2024
@github-actions github-actions bot added [Platform] Simple [Pri] Normal Schedule for the next available opportuinity. labels Dec 25, 2024
Copy link

Support References

This comment is automatically generated. Please do not edit it.

  • 9209528-zen

@github-actions github-actions bot added the Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". label Dec 25, 2024
@ramonjd
Copy link
Member

ramonjd commented Dec 27, 2024

I think this will be fixed by:

The bug affects all typography changes to the Button block.

@ramonjd
Copy link
Member

ramonjd commented Dec 31, 2024

WordPress/gutenberg#68023 has been merged so this issue should be fixed with Gutenberg 20 🤞🏻

@valterlorran valterlorran moved this from Needs Triage to In Progress in Automattic Prioritization: The One Board ™ Dec 31, 2024
@valterlorran valterlorran added the Groundskeeping Issues handled through Dotcom Groundskeeping rotations label Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Block Rendering Blocks Editor blocks, aka Gutenberg blocks, plugins, and extensions Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Feature] Core Blocks Blocks that come with Gutenberg. [Feature Group] Appearance & Themes Features related to the appearance of sites. [Feature] .Org Themes Core themes imported from the WordPress.org repository. Groundskeeping Issues handled through Dotcom Groundskeeping rotations Needs triage Ticket needs to be triaged [Platform] Simple [Pri] Normal Schedule for the next available opportuinity. [Product] WordPress.com All features accessible on and related to WordPress.com. [Type] Bug
Projects
Development

No branches or pull requests

4 participants