This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
[Reverted] Fix: Share Params Between Physical and Simulation Testing Launch Files #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanssitis
changed the title
alanssitis
changed the title
ihagedo
approved these changes
Oct 26, 2021
|
I agree with @ihagedo . What I typically do when I have made good progress on something and want to push it but not open up for code review is mark the PR as a draft. I marked yours as a draft so feel free to hit "ready for review" once you are done. |
zghera
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is a quick description of the change?
Modifying parameters in launch files.
Is this fixing an issue?
Resolves Autonomous-Motorsports-Purdue/AMP_ASSv2#25
Were any issues created as a result of this change?
Autonomous-Motorsports-Purdue/AMP_ASSv2#25
Are there more details that are relevant?
Currently a work in progress.
Check lists (check x in [ ] of list items)
Test written/updating
Tests passing
Coding style (indentation, etc)
Update the robot/sensor specific params in
src/kart_2dnav/params/indicated by theTODOs with direct measurements from the kart or from the Velodyne LiDAR documentation (e.g. sensor range to update the obstacle_range parameter in costmap_common_params).Additionally static transforms for the kart are defined in
src/static_tf_config/launch/static_transforms_config.launch. These transform values should be re-measured and verified (originally Update Static Transforms with Correct Values #5).Fix the simulation so that it works with the new parameters. This may mean altering the size of the map we use (size per grid square param for rviz) or creating a new map altogether.
Any additional comments?