From e38b9e446c300641e46717735b66b7241956f59d Mon Sep 17 00:00:00 2001 From: Jean-Noel Ribelles Date: Mon, 8 Jul 2019 14:22:23 +0900 Subject: [PATCH 1/5] Two errors found during CD hands on lab: invalid json (comma), and the debugger options (VS version) not supported error during the ARM template deployment. --- source/deploy/azuredeploy.json | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/source/deploy/azuredeploy.json b/source/deploy/azuredeploy.json index 847628f..9e3018d 100644 --- a/source/deploy/azuredeploy.json +++ b/source/deploy/azuredeploy.json @@ -19,7 +19,7 @@ "2" ], "defaultValue": "0" - }, + } }, "resources": [ { @@ -62,8 +62,7 @@ "webSocketsEnabled": true, "alwaysOn": true, "remoteDebuggingEnabled": true, - "remoteDebuggingVersion": "VS2013", - + "remoteDebuggingVersion": "VS2017", "defaultDocuments": [ "index.html", "hostingstart.html" From 90ebc000de3cf8e0782d950042fd43128ad62e06 Mon Sep 17 00:00:00 2001 From: Jean-Noel Ribelles Date: Mon, 8 Jul 2019 14:50:25 +0900 Subject: [PATCH 2/5] AAD and Microsoft account problem related explanation added. --- getting-started/README.md | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/getting-started/README.md b/getting-started/README.md index 183eefb..36786e3 100644 --- a/getting-started/README.md +++ b/getting-started/README.md @@ -6,7 +6,15 @@ In this lab, we will be installing the required development components and verif [Azure Portal](https://portal.azure.com) 2. An active Azure DevOps account.
[Sign up for Visual Studio Team Services](https://azure.microsoft.com/en-us/services/devops/) - +3. Having your subscription linked with your own Azure Active Directory instance
+ If you use your Avanade email address as a Micrsoft account, you may have problems related to write permissions into the Azure Active Directory managed by Avanade (avanade.onmicrosoft.com).
+ As a result you won't be able to create multiple services in Azure that require registering a Service Principal account in the AD (e.g.: creating a Service Connection in Azure DevOps, creating a new Kubernetes cluster, etc.).
+ To prevent that and save you lots of frustrations in the future, create a new Active Directory from the [Azure Portal](https://portal.azure.com) , "Create a resource" menu (search for Active directory).
+ Once created, find the Subscriptions menu and select your "Visual Studio ********" subscription Overview blade (or the subscription you will use for this lab).
+ A "Change directory" option in the upper bar will allow you to attach this subscription to the newly created Azure Active Directory instance.
+ The migration process requires between 10 and 30 minutes so please be sure to perform this operation before the Lab.
+ [Associate or add an Azure subscription to your Azure Active Directory tenant](https://docs.microsoft.com/en-us/azure/active-directory/fundamentals/active-directory-how-subscriptions-associated-directory) + ## Set up your machine ## 1. Install [Visual Studio 2017](http://go.microsoft.com/fwlink/?LinkId=517106)
Select ASP.NET and web development and Azure development tools on the installer. From 06431cdee464d8260f89f5ec74531a5a9b7bb4d1 Mon Sep 17 00:00:00 2001 From: Jean-Noel Ribelles Date: Mon, 8 Jul 2019 15:03:30 +0900 Subject: [PATCH 3/5] Duplicate with the top Readme file. Added a reference where needed instead of copying the content. --- continuous-deployment/README.md | 3 ++- getting-started/README.md | 8 +------- 2 files changed, 3 insertions(+), 8 deletions(-) diff --git a/continuous-deployment/README.md b/continuous-deployment/README.md index 83daea4..faa1eba 100644 --- a/continuous-deployment/README.md +++ b/continuous-deployment/README.md @@ -4,7 +4,8 @@ In this lab, you have an example MVC application, committed to a Git repository ### Pre-requisites: ### - Complete [Continuous Integration](../continuous-integration/README.md) lab. - +- Having your subscription linked with your own Azure Active Directory instance
+ Check the [Course Pre-Requisites #1](..\README.md#course-pre-requisites) ### Tasks Overview: ### diff --git a/getting-started/README.md b/getting-started/README.md index 36786e3..0611e2a 100644 --- a/getting-started/README.md +++ b/getting-started/README.md @@ -7,13 +7,7 @@ In this lab, we will be installing the required development components and verif 2. An active Azure DevOps account.
[Sign up for Visual Studio Team Services](https://azure.microsoft.com/en-us/services/devops/) 3. Having your subscription linked with your own Azure Active Directory instance
- If you use your Avanade email address as a Micrsoft account, you may have problems related to write permissions into the Azure Active Directory managed by Avanade (avanade.onmicrosoft.com).
- As a result you won't be able to create multiple services in Azure that require registering a Service Principal account in the AD (e.g.: creating a Service Connection in Azure DevOps, creating a new Kubernetes cluster, etc.).
- To prevent that and save you lots of frustrations in the future, create a new Active Directory from the [Azure Portal](https://portal.azure.com) , "Create a resource" menu (search for Active directory).
- Once created, find the Subscriptions menu and select your "Visual Studio ********" subscription Overview blade (or the subscription you will use for this lab).
- A "Change directory" option in the upper bar will allow you to attach this subscription to the newly created Azure Active Directory instance.
- The migration process requires between 10 and 30 minutes so please be sure to perform this operation before the Lab.
- [Associate or add an Azure subscription to your Azure Active Directory tenant](https://docs.microsoft.com/en-us/azure/active-directory/fundamentals/active-directory-how-subscriptions-associated-directory) + Check the [Course Pre-Requisites #1](..\README.md#course-pre-requisites) ## Set up your machine ## 1. Install [Visual Studio 2017](http://go.microsoft.com/fwlink/?LinkId=517106)
From 5de32101a5c05169e4b63f2e966b8d776d375920 Mon Sep 17 00:00:00 2001 From: Jean-Noel Ribelles Date: Mon, 8 Jul 2019 15:07:41 +0900 Subject: [PATCH 4/5] Commited too fast, sorry. --- continuous-deployment/README.md | 2 +- getting-started/README.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/continuous-deployment/README.md b/continuous-deployment/README.md index faa1eba..ca2e8ff 100644 --- a/continuous-deployment/README.md +++ b/continuous-deployment/README.md @@ -5,7 +5,7 @@ In this lab, you have an example MVC application, committed to a Git repository ### Pre-requisites: ### - Complete [Continuous Integration](../continuous-integration/README.md) lab. - Having your subscription linked with your own Azure Active Directory instance
- Check the [Course Pre-Requisites #1](..\README.md#course-pre-requisites) + Check the [Course Pre-Requisites #1](../README.md#course-pre-requisites) ### Tasks Overview: ### diff --git a/getting-started/README.md b/getting-started/README.md index 0611e2a..a494780 100644 --- a/getting-started/README.md +++ b/getting-started/README.md @@ -7,7 +7,7 @@ In this lab, we will be installing the required development components and verif 2. An active Azure DevOps account.
[Sign up for Visual Studio Team Services](https://azure.microsoft.com/en-us/services/devops/) 3. Having your subscription linked with your own Azure Active Directory instance
- Check the [Course Pre-Requisites #1](..\README.md#course-pre-requisites) + Check the [Course Pre-Requisites #1](../README.md#course-pre-requisites) ## Set up your machine ## 1. Install [Visual Studio 2017](http://go.microsoft.com/fwlink/?LinkId=517106)
From e5ec6da035de21e6634a5660c34899010457b059 Mon Sep 17 00:00:00 2001 From: Jean-Noel Ribelles Date: Tue, 9 Jul 2019 10:23:01 +0900 Subject: [PATCH 5/5] Cast problem in the code. Added notes about using the feature toggle live. --- feature-flag/README.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/feature-flag/README.md b/feature-flag/README.md index eed4925..fc8fe8e 100644 --- a/feature-flag/README.md +++ b/feature-flag/README.md @@ -108,7 +108,7 @@ Based on [this](https://microsoft.github.io/PartsUnlimited/apm/200.6x-APM-Featur public void ConfigureServices(IServiceCollection services) { // Set provider config so file is read from content root path - var provider = new AppSettingsProvider { Configuration = (IConfiguration)Configuration }; + var provider = new AppSettingsProvider { Configuration = (IConfigurationRoot)Configuration }; // Add your feature here services.AddSingleton(new CheckPhoneNumber { ToggleValueProvider = provider }); @@ -164,6 +164,7 @@ Based on [this](https://microsoft.github.io/PartsUnlimited/apm/200.6x-APM-Featur 1. Enter phone number 123-123-5678, submit and notice the page refreshes without error 1. Push your code changes and let your pipeline do it's job + - Note (optional): You can override the feature toggle setting value defined in the appsettings.json file by using the Azure Web App settings screen (Azure portal > your Web app > Settings > Configuration panel). Open your production Web app configuration panel and try adding a new Application Setting called FeatureToggle:CheckPhoneNumber then assign it with either true or false. Hit the Save button and refresh the Contact page in your Production environment to check the feature toggle in action. ## Next steps