Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cherry-pick]: FA 3008 #27

Closed
IT-VBFK opened this issue Feb 10, 2025 · 4 comments
Closed

[cherry-pick]: FA 3008 #27

IT-VBFK opened this issue Feb 10, 2025 · 4 comments
Labels
bug Something isn't working

Comments

@IT-VBFK
Copy link

IT-VBFK commented Feb 10, 2025

Description

fluentassertions/fluentassertions#3008

Reproduction Steps

// Arrange
string input = "MyString";

// Act
char result = input[0];

// Assert
result.Should().Be('M');

Expected behavior

Actual behavior

Regression?

No response

Known Workarounds

No response

Configuration

No response

Other information

No response

Are you willing to help with a pull-request?

No

@IT-VBFK IT-VBFK added the bug Something isn't working label Feb 10, 2025
@cbersch
Copy link
Contributor

cbersch commented Feb 16, 2025

That should then be the proper fix for #23, right?

@IT-VBFK
Copy link
Author

IT-VBFK commented Feb 19, 2025

Yeah I think so

@ScarletKuro
Copy link
Contributor

ScarletKuro commented Feb 21, 2025

We might want to continue with #23 and the PR #24. The fluentassertions/fluentassertions#3008 was closed and it doesn't seem like it made it to the 7.2.0, and since it didn't make it to v7 version I do not want to risk and pick this up, it's totally not the same situation as here #26 (comment).

Also, the branch https://github.com/fluentassertions/fluentassertions/tree/support-7.0 was removed (seems it means the v7 support has ended already), which is why I didn't want that we do any cross reference to the FA issues/PR that would show up in their feed but I forgot to warn, but anyway soon or later this would happen anyway since it is not profitable for them because anything that from v8 gets backported to v7 gets automatically legal to be cherry picked and they would notice us later anyway as AwesomeAssertions is being mentioned in many places. But just wanted to let you know that we are completely on our own for now on.

@cbersch
Copy link
Contributor

cbersch commented Feb 22, 2025

@ScarletKuro I agree, I'll move on with #23. It is also a proper fix, so we can move on with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants